Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 312074

Summary:

The "Link Source' wizard in the Build Path property page does not show Project Path Variables

Product:

[Eclipse Project] JDT

Reporter:

Serge Beauchamp <serge>

Component:

Assignee:

Deepak Azad <deepakazad>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, raksha.vasisht

Version:

3.6

Flags:

daniel_megert: review+
raksha.vasisht: review+

Target Milestone:

3.6 RC2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
fix	none
reworked patch	daniel_megert: review+

Description Serge Beauchamp

2010-05-07 10:43:04 EDT

Reproducible: Always

Steps to Reproduce:
* In the Java perspective, right click a Java project, goto Build Path > Link
Source...
* Select Variables...

Notice that none of the project path variables are listed (to see the project path variable list, see the property page "Resource / Linked Resources").

This is done by adding in 'AddSourceFolderWizardPage.java" line 171:

PathVariableSelectionDialog dialog = new PathVariableSelectionDialog(getShell(), variableTypes);
dialog.setResource(fParent);

Note that internally, the resolution of that Path (if done manually) must call IResource.getPathVariableManager() instead of IWorkspace.getPathVariableManager().

Comment 1 Dani Megert

2010-05-11 11:49:51 EDT

Deepak, can you check how much work this would be and whether it makes sense that clients have to fill in/resolve that information?

Comment 2 Dani Megert

2010-05-12 12:51:46 EDT

Deepak, if you don't see what's going on then please reassign to me.

Most likely we'll defer this to 3.7.

Comment 3 Deepak Azad

2010-05-18 08:27:58 EDT

Created attachment 168907 [details]
fix

Fix as per Serge's suggestions.

Comment 4 Dani Megert

2010-05-18 08:51:39 EDT

+1 for RC2.

To reduce code duplication I would assign
fNewElement.getJavaProject().getProject()
to a local variable (same code already used a few lines above).

Please attach a new patch and ask Raksha for review.

There's also a second reference to IPathVariableManager.resolvePath(IPath) but that code is no longer used (filed bug 313339 to remove this for 3.7).

Comment 5 Serge Beauchamp

2010-05-18 08:56:16 EDT

That looks great. thanks

Comment 6 Deepak Azad

2010-05-18 10:32:58 EDT

Created attachment 168938 [details]
reworked patch

Comment 7 Raksha Vasisht

2010-05-19 05:00:26 EDT

Patch is good.

Comment 8 Deepak Azad

2010-05-19 05:16:48 EDT

Patch released to HEAD.

Comment 9 Raksha Vasisht

2010-05-19 05:18:12 EDT

Dani, I have a question : Why do we allow to create a new Variable using a Variable location recursively? I could do this operation 

* In the Java perspective, right click a Java project, goto Build Path > Link
Source...
* Select Variables... (Lets say you already have a variable 'x')
* Create a new variable using New... button
* Say 'y', use 'Variables...' to select location
* Remove... 'x', select some other variable location , OK 
 => In the old dialog , you can still see the removed variable in the list
That variable is never removed from the list even after you finish all the dialogs.

Should we allow 'New/Edit/Remove' operations recursively at all or should we only allow it once and then use another dialog to show only the list for selection?

Comment 10 Serge Beauchamp

2010-05-19 05:20:45 EDT

(In reply to comment #9)
> Dani, I have a question : Why do we allow to create a new Variable using a
> Variable location recursively? I could do this operation 
> 
> * In the Java perspective, right click a Java project, goto Build Path > Link
> Source...
> * Select Variables... (Lets say you already have a variable 'x')
> * Create a new variable using New... button
> * Say 'y', use 'Variables...' to select location
> * Remove... 'x', select some other variable location , OK 
>  => In the old dialog , you can still see the removed variable in the list
> That variable is never removed from the list even after you finish all the
> dialogs.
> 
> Should we allow 'New/Edit/Remove' operations recursively at all or should we
> only allow it once and then use another dialog to show only the list for
> selection?

This dialog is a standard ui.ide dialog, not a JDT specific one, and there's an open bug tracking this issue: Bug 312084

Comment 11 Raksha Vasisht

2010-05-19 06:20:09 EDT

(In reply to comment #10)
> (In reply to comment #9)
> This dialog is a standard ui.ide dialog, not a JDT specific one, and there's an
> open bug tracking this issue: Bug 312084

Okay, I have added my comment there. Thanks!

Comment 12 Dani Megert

2010-05-20 07:11:29 EDT

Verified in N20100519-2000.