Bugzilla – Full Text Bug Listing
| Summary: | [editor] Source validation requires saving file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] JSDT | Reporter: | Eugene Ostroukhov <eostroukhov> | ||||
| Component: | General | Assignee: | Nitin Dahyabhai <thatnitind> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Nitin Dahyabhai <thatnitind> | ||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | cmjaun, david_williams | ||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
thatnitind: pmc_approved? (raghunathan.srinivasan) thatnitind: pmc_approved? (naci.dai) thatnitind: pmc_approved? (deboer) thatnitind: pmc_approved? (neil.hauge) thatnitind: pmc_approved? (kaloyan) cmjaun: review+ |
||||
| Target Milestone: | 3.2 RC2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows Vista | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
Created attachment 168811 [details]
proposed patch
Attaching a patch that rolls back a fix for accessing a deprecated method from the CompilationUnitDocumentProvider. The editor's annotation model requires the method's use so that the problems reported by reconciling the editor contents can be known.
Looks fine to me. * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. As-you-type validation a key feature of any good Eclipse-based editor. That it worked in Galileo and might not work in Helios is unacceptable. * Is there a work-around? If so, why do you believe the work-around is insufficient? Any workaround would be more complicated. * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manually tested. * Give a brief technical overview. Who has reviewed this fix? Reviewed by Chris Jaun. The re-adds two deprecated methods that were removed from an interface early in 3.2 and updates the CompilationUnitDocumentProvider to use them. The CUDP needs to use the deprecated method so that it can listen for problems reported when reconciling the editor contents; those results are the basis of the "as-you-type" warnings and errors. The changes include updated doc in the interface clarifying when the deprecated method should still be used and updated doc in the CUDP identifying why the deprecated method is used there. * What is the risk associated with this fix? Low. This is a rollback of changes to an interface long identified as not to be implemented by clients, and its subclasses still retained the implementations of the methods being added back. I'll approve this, but IMHO, starting to approach that gray area of not-that-bad-a-problem. Released for RC2. |
1. Create a new JS project. 2. Create a new JS file. 3. Type following JS code: var a = new Object(); a.afield = 5 In 3.5.2 there will be yellow squiggles at the end of the line 2. 3.6M6 will not show squiggles until the file is saved.