Bugzilla – Full Text Bug Listing
| Summary: | HTML editor template doesn't handle "%" signs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||
| Component: | Core | Assignee: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david_williams | ||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai) raghunathan.srinivasan: pmc_approved? (deboer) raghunathan.srinivasan: pmc_approved? (neil.hauge) raghunathan.srinivasan: pmc_approved? (kaloyan) raghunathan.srinivasan: review+ |
||||
| Target Milestone: | 3.2 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
|
Description
Raghunathan Srinivasan
Created attachment 167396 [details]
Patch to fix Facelet HTML templates
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. Creating a XHTML page using the header and footer facelet template, the resulting page ignores the '%' character and also inject spurios, '!' character. This is annoying and will affect end-user experience. * Is there a work-around? If so, why do you believe the work-around is insufficient? Manuall edit the resulting file * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manual testing. * Give a brief technical overview. Who has reviewed this fix? See comment 1 * What is the risk associated with this fix? None I'm sorry ... its late in the day ... but I don't see what the fix is, here. The patch has changes that don't appear to be related to this bug. Fine, looks minor. But worst, I don't see how width:100&37; was changed. Can you spell it out for me? Sounds like a good fix for a very important problem, so I'm sure its fine. I'd like to understand the principle that leads to the solution. Is that principle documented? Is there some "best practice" to follow in the future? Or were these some sort of typo. (In reply to comment #3) > I'm sorry ... its late in the day ... but I don't see what the fix is, here. > > The patch has changes that don't appear to be related to this bug. Fine, looks > minor. But worst, I don't see how width:100&37; was changed. Can you spell it > out for me? The patch moves the HTML text in the template.xml file to a properties file, where width is specified as "width:100%" . When used to create the XHTML file, the '%' is preserved and is not interpreted as a translation string. > > Sounds like a good fix for a very important problem, so I'm sure its fine. I'd > like to understand the principle that leads to the solution. Is that principle > documented? Is there some "best practice" to follow in the future? Or were > these some sort of typo. From :See https://bugs.eclipse.org/bugs/show_bug.cgi?id=242119#c2 : Looks to be in Platform code in TemplateReaderWriter. % gets unescaped into a %, but then the string gets translated starting at that %. Since the string key is not found in the bundle, you get the !! surrounding the "key" which is everything up until the newline (where your </div> ends). k, thanks for spelling it out for me. Patch released to RC1 |