Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311946

Summary: [debug view] TerminateAndRemove delete key short-cut works only for the launch element in view
Product: [Tools] CDT Reporter: Pawel Piech <pawel.1.piech>
Component: cdt-debug-dsfAssignee: Project Inbox <cdt-debug-dsf-inbox>
Status: NEW --- QA Contact: Jonah Graham <jonah>
Severity: normal    
Priority: P3 CC: darin.eclipse, h.klene, pawel.1.piech
Version: 7.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch with fix. none

Description Pawel Piech CLA 2010-05-06 14:23:04 EDT 
Created attachment 167359 [details]
Patch with fix.

There are two issuew preventing the handler from working:

1) The TerminateAndRemove command handler has tests whether an element is instanceof IRestart class (instead of the more generic IRestartHandler).

2) The hander uses the standard expression <adapt... test.  However, due to bug 201743 this test fails if the element adapts to IRestartHandler by implementing IAdaptable.getAdapter() directly.

The attached patch addresses both issues.
Comment 1 Darin Wright CLA 2010-05-06 14:29:59 EDT 
See bug 290219 - we intentionally do not want to support the "delete" key binding/handler on non-standard objects, such that others may provide their own custom function.
Comment 2 Pawel Piech CLA 2010-05-06 14:41:27 EDT 
(In reply to comment #1)
> See bug 290219 - we intentionally do not want to support the "delete" key
> binding/handler on non-standard objects, such that others may provide their own
> custom function.

Fair enough, in this case I'll move it to DSF, though the fix will probably be different.
Comment 3 Holger Klene CLA 2012-04-14 08:46:58 EDT 
If the delete key is to dangerous how about enabling the toolbar-button to remove all terminated launches? In Console view it's enabled automatically. In Debug view it currently requires activation of the debug view.