Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311928

Summary:	IGDBJtagDevice should use generics
Product:	[Tools] CDT	Reporter:	John Cortell <john.cortell>
Component:	cdt-debug	Assignee:	Elena Laskavaia <elaskavaia.cdt>
Status:	RESOLVED FIXED	QA Contact:	Ken Ryall <ken.ryall>
Severity:	normal
Priority:	P3	CC:	elaskavaia.cdt, pawel.1.piech
Version:	7.0
Target Milestone:	7.0
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description John Cortell

2010-05-06 12:38:25 EDT

Nearly all the methods take a type-less Collection. The advantages of type-safe collections are beyond debate. To argue for the widespread use of typeless collections is akin to arguing for the use of Object as parameter types. We can switch the JtagDevice interface and built-in implementations to use Collection<String> with no adverse impact to clients because of how generics work under the covers.

Comment 1 Elena Laskavaia

2010-05-06 13:08:10 EDT

I think I bit you to it. I commit the update 30 min  before you submitted the bug.

Comment 2 Elena Laskavaia

2010-05-06 13:11:19 EDT

fixed

Comment 3 John Cortell

2010-05-06 14:27:24 EDT

(In reply to comment #1)
> I think I bit you to it. I commit the update 30 min  before you submitted the
> bug.

Indeed you did. The downstream weren't updated, though. I've taken care of them. Also, I updated the javadoc for the jtagdevice interface to make it clear that the implementor is supposed to populate the collection with gdb commands.