Bugzilla – Full Text Bug Listing
| Summary: | Synchronize view has duplicate mnemonic | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Benjamin Muskalla <b.muskalla> | ||||||||
| Component: | Team | Assignee: | Tomasz Zarna <tomasz.zarna> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P4 | CC: | pawel.pogorzelski1 | ||||||||
| Version: | 3.6 | Flags: | Szymon.Brandys:
review-
pawel.pogorzelski1: review+ |
||||||||
| Target Milestone: | 3.7 M2 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Benjamin Muskalla
Good catch! The same thing with with "Open" and "Open In Compare Editor", they both have "o" as mnemonic. Created attachment 168708 [details]
Fix v01
Sets "k" for "Mark as merged", and "e" for "Open In Compare Editor". I haven't noticed any conflicts for the new mnemonics.
Created attachment 168709 [details]
mylyn/context/zip
Other duplicated mnemonics in the context menu are: C - 'Copy' & 'Commit' V - 'Move' & 'Override and Update' D - 'Delete' & 'Add to cvsignore' P - 'Paste Patch' & 'Create Patch' After a discussion with Tomasz, we came to the following conclusions. 1) These are mostly old mnemonic. Only 'Paste patch' is a new action. 2) It is not said that we have to get rid of duplicated mnemonics at all costs. We can leave those that makes sense and the user has to just iterate trough them. 3) We should not change the old mnemonics at this point of 3.6, since users could get used to some of them already and it would be potentially disruptive for them. 4) I think mnemonics for common actions like 'Move' should be consistent with Project Explorer. Right now, the mnemonic for 'Move' in the Sync View context menu is 'v' and in Project Explorer is 'm'. We should consider fixing this. Thus I think we should move the issue to 3.7. Szymon, I'm with you regarding the "do not break customers that late the in cycle" but at least the original request (Rename and Mark as merged) was broken late in the cycle. I'm using Mark as merged daily and it was not a conflict in earlier versions. I really hope to get at least this fixed in the 3.6 timeframe as merging is an essential task in the synchronize view. The conflict existed in 3.5, in 3.4 the "Rena&me" action was available in "Edi&t" submenu[1] and that's why it didn't surfaced then. What you probably consider as a breakage introduced late in the cycle, is caused by the fact that "Rena&me" does not show up for all objects in the Sync view (in model sync it's available for "pure" resource objects only). I'm pretty sure, we haven't changed the mnemonic for "Mark as merged" recently. [1] the action is also hidden in the submenu for non-model syncs The sooner the better... I hope I'll find some time to fix this in 3.7M2. Created attachment 177927 [details] Fix v02 The patch changes mnemonics for Team/CVS actions as follows: * Override and Update - i, no conflict found for the new mnemonic * Add to .cvsignore - g, no conflict found for the new mnemonic * Create Patch - t, no conflict found for the new mnemonic * Mark as Merged - k, no conflict found for the new mnemonic * Open in Compare Editor - e, no conflict found for the new mnemonic * Commit - I haven't changed the current c which is conflicting with Copy. This action is used very often, so I decided to leave the mnemonic as it is to not confuse users. * Paste Patch - left p as this is actually a replacement for the Paste action I haven't seen any mnemonics for common actions to be consistent with Project Explorer (bullet 4 in comment 5). Fixed in HEAD, available in builds >N20100831-2000. Benny could you please verify it? Verified on I20100912-2000. |