Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311854

Summary: Editor navigation history is non-existent
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED FIXED QA Contact: Oleg Besedin <ob1.eclipse>
Severity: normal    
Priority: P3 CC: bokowski, ob1.eclipse
Version: 1.0   
Target Milestone: 1.0 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch none

Description Remy Suen CLA 2010-05-06 07:17:25 EDT
This is what happens when an editor is activated on 3.x.

Thread [main] (Suspended (breakpoint at line 182 in NavigationHistory))	
	NavigationHistory.markEditor(IEditorPart) line: 182	
	WorkbenchPage.makeActiveEditor(IEditorReference) line: 1272	
	WorkbenchPage.setActivePart(IWorkbenchPart, boolean) line: 3530	
	WorkbenchPage.requestActivation(IWorkbenchPart) line: 3077	
	EditorPane(PartPane).requestActivation() line: 279	
	EditorPane.requestActivation() line: 98	
	EditorPane(PartPane).setFocus() line: 325	
	EditorPane.setFocus() line: 127	
	EditorStack(PartStack).presentationSelectionChanged(IPresentablePart) line: 844	
	PartStack.access$1(PartStack, IPresentablePart) line: 827	
	PartStack$1.selectPart(IPresentablePart) line: 137	
	TabbedStackPresentation$1.handleEvent(TabFolderEvent) line: 133	
	DefaultTabFolder(AbstractTabFolder).fireEvent(TabFolderEvent) line: 269	
	DefaultTabFolder(AbstractTabFolder).fireEvent(int, AbstractTabItem) line: 278	
	DefaultTabFolder.access$1(DefaultTabFolder, int, AbstractTabItem) line: 1	
	DefaultTabFolder$2.handleEvent(Event) line: 88	
	EventTable.sendEvent(Event) line: 84	
	CTabFolder(Widget).sendEvent(Event) line: 1052	
	CTabFolder(Widget).sendEvent(int, Event, boolean) line: 1076	
	CTabFolder(Widget).sendEvent(int, Event) line: 1061	
	CTabFolder(Widget).notifyListeners(int, Event) line: 773	
	CTabFolder.setSelection(int, boolean) line: 2736	
	CTabFolder.onPageTraversal(Event) line: 1664	
	CTabFolder.onTraverse(Event) line: 1790	
	CTabFolder$1.handleEvent(Event) line: 264	
	EventTable.sendEvent(Event) line: 84	
	CTabFolder(Widget).sendEvent(Event) line: 1052	
	CTabFolder(Widget).sendEvent(int, Event, boolean) line: 1076	
	CTabFolder(Widget).sendEvent(int, Event) line: 1061	
	CTabFolder(Control).traverse(Event) line: 3692	
	CTabFolder(Control).traverse(int) line: 3731	
	PartPane$1.keyTraversed(TraverseEvent) line: 95	
	TypedListener.handleEvent(Event) line: 247	
	EventTable.sendEvent(Event) line: 84	
	Composite(Widget).sendEvent(Event) line: 1052	
	Composite(Widget).sendEvent(int, Event, boolean) line: 1076	
	Composite(Widget).sendEvent(int, Event) line: 1061	
	Composite(Control).traverse(Event) line: 3692	
	StyledText(Control).translateTraversal(MSG) line: 3674	
	StyledText(Composite).translateTraversal(MSG) line: 1218	
	Display.translateTraversal(MSG, Control) line: 4691	
	Display.filterMessage(MSG) line: 1267	
	Display.readAndDispatch() line: 3653	
	Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 2601	
	Workbench.runUI() line: 2565	
	Workbench.access$4(Workbench) line: 2399	
	Workbench$7.run() line: 669	
	Realm.runWithDefault(Realm, Runnable) line: 332	
	Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 662	
	PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 149	
	IDEApplication.start(IApplicationContext) line: 115	
	EclipseAppHandle.run(Object) line: 196	
	EclipseAppLauncher.runApplication(Object) line: 110	
	EclipseAppLauncher.start(Object) line: 79	
	EclipseStarter.run(Object) line: 369	
	EclipseStarter.run(String[], Runnable) line: 179	
	NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]	
	NativeMethodAccessorImpl.invoke(Object, Object[]) line: 79	
	DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43	
	Method.invoke(Object, Object...) line: 618	
	Main.invokeFramework(String[], URL[]) line: 619	
	Main.basicRun(String[]) line: 574	
	Main.run(String[]) line: 1407	
	Main.main(String[]) line: 1383
Comment 1 Oleg Besedin CLA 2010-06-21 16:11:02 EDT
Setting to RC1 for now, but I am not sure of the scope...
Comment 2 Oleg Besedin CLA 2010-07-08 11:44:12 EDT
Created attachment 173783 [details]
Patch
Comment 3 Oleg Besedin CLA 2010-07-08 11:45:23 EDT
Patch applied to CVS Head.