Bugzilla – Full Text Bug Listing
| Summary: | [Perspectives] [Min/Max] Maximize and Minimizing views causes nullpointer exception | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Johan Asterholm <johan.asterholm> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Eric Moffatt <emoffatt> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | pwebster, remy.suen | ||||
| Version: | 3.6 | Flags: | remy.suen:
review+
pwebster: review+ |
||||
| Target Milestone: | 3.6 RC2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Johan Asterholm
(In reply to comment #0) > 1. open java perspective > 2. maximise a view > 3. click on one of the icons on the side to show another view. > 4. maximise this one. > 5. open another perspective. Could not reproduce with I20100429-1549 on Windows XP. This is what I tried. 1. Start Eclipse on a new workspace. 2. Close the 'Welcome' view. 3. Select the 'Package Explorer'. 4. Ctrl+M to maximize it. 5. Select the 'Javadoc' view at the bottom right hand corner. 6. Ctrl+M to maximize it. 7. Window > Open Perspective > Debug 8. Nothing in the error log. (In reply to comment #1) > (In reply to comment #0) > > 1. open java perspective > > 2. maximise a view > > 3. click on one of the icons on the side to show another view. > > 4. maximise this one. > > 5. open another perspective. > > Could not reproduce with I20100429-1549 on Windows XP. This is what I tried. > > 1. Start Eclipse on a new workspace. > 2. Close the 'Welcome' view. > 3. Select the 'Package Explorer'. > 4. Ctrl+M to maximize it. > 5. Select the 'Javadoc' view at the bottom right hand corner. > 6. Ctrl+M to maximize it. > 7. Window > Open Perspective > Debug > 8. Nothing in the error log. The problem seems to work fine when using Ctrl+M. But recreatable when using the icons to maximize. (In reply to comment #2) > The problem seems to work fine when using Ctrl+M. But recreatable when using > the icons to maximize. By icons I presume you mean by double-clicking the tab, yes? I can reproduce the problem by double-clicking the tab. The only way to get out of this state that I can see is to reset the perspective. (In reply to comment #3) > (In reply to comment #2) > > The problem seems to work fine when using Ctrl+M. But recreatable when using > > the icons to maximize. > > By icons I presume you mean by double-clicking the tab, yes? I can reproduce > the problem by double-clicking the tab. The only way to get out of this state > that I can see is to reset the perspective. Ether double clicking the tab, or pressing maximum button reproduces it for me. (In reply to comment #4) > Ether double clicking the tab, or pressing maximum button reproduces it for me. Ah okay, you were talking about the button in the top right part of a given tab (folder). Dang, I thought I'd covered this one. The fix appears to be to move the 'setActiveFastView(null)' in Perspective#deactivate() above 'presentation.deactivate()' to ensure that there's no fast view open when de-activating the presentation...patch coming. Created attachment 168919 [details]
Patch that closes any open FV before deactivating the perspective
Also contains a fix that was causing the originally maximized view (in the real presentation) to become unmaximized.
(In reply to comment #7) > Created an attachment (id=168919) [details] > Patch that closes any open FV before deactivating the perspective +1 I've tested scenarios with views and fastviews from the trim, and the problem has been fixed. PW (In reply to comment #7) > Created an attachment (id=168919) [details] > Patch that closes any open FV before deactivating the perspective +1, the problem is fixed on Windows XP and the tests are green on my computer. Committed in >20100519. Applied the patch. Fixed. Verified in I20100520-1744. |