Bugzilla – Full Text Bug Listing
| Summary: | return statement missing in JavaBreakpointListenerProxy#installingBreakpoint | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Jürgen King <j.king> | ||||
| Component: | Debug | Assignee: | Darin Wright <darin.eclipse> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | darin.eclipse, Michael_Rennie | ||||
| Version: | 3.6 | Flags: | Michael_Rennie:
review+
|
||||
| Target Milestone: | 3.6 RC1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 167302 [details]
patch
Yes, this is a bug.
Pleaes review, Mike. Ping Mike for RC1 review. +1 applied to HEAD |
Build Identifier: M20090917-0800 The installBreakpoint Method in JavaBreakpointListenerProxy (a inner class of BreakpointListenerManager) is implemented this way: public int installingBreakpoint(IJavaDebugTarget target, IJavaBreakpoint breakpoint, IJavaType type) { IJavaBreakpointListener delegate = getDelegate(); if (delegate != null) { delegate.installingBreakpoint(target, breakpoint, type); } return IJavaBreakpointListener.DONT_CARE; } This way the return of the delegate is ignored. To me the correct statement would be: return delegate.installingBreakpoint(target, breakpoint, type); like it is in breakpointHit. Reproducible: Always