Bugzilla – Full Text Bug Listing
| Summary: | P2 provisioning of a target platform does not take into account the execution profile | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Hugues Malphettes <hmalphettes> | ||||
| Component: | UI | Assignee: | PDE-UI-Inbox <pde-ui-inbox> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | david_williams, gunnar, hmalphettes, holger.herzog, jeffmcaffer | ||||
| Version: | 3.6 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | stalebug | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 307571 | ||||||
| Attachments: |
|
||||||
|
Description
Hugues Malphettes
After further research I stumbled upon: http://dev.eclipse.org/mhonarc/lists/p2-dev/msg02500.html I'll try to find out what type of IUs the jetty site need to generate. You can try running a product build. :) I'm not sure, but I also heard that sometimes people depend on "system.bundle" explicitly. But I'm not sure if it was in that context. Thanks Gunnar for looking at it. I think there are 2 ways to tackle this: 1- on the p2-repository generated from an update site with the http://wiki.eclipse.org/Equinox/p2/Publisher#UpdateSite_Publisher_Application So far the best explanation I have found is: http://www.eclipse.org/forums/index.php?t=msg&goto=502560 We are using tycho to generate our site and I am diving into the publisher part of it so maybe I'll stumble onto a way to do this. 2- On the PDE side: insert the <unit id='a.jre.javase' version='1.6.0' singleton='false'> (for example) according to the tab. At least that is my understanding. Of course on this bug filed against PDE we are focusing on the approach #2. It would be great if someone could review this and let us know if that is a good idea I would be quite grateful. For approach #1 I have not found out the reason why the UpdateSite Publisher Application does not generate the JRE IU. (In reply to comment #2) > You can try running a product build. :) Yes when I build a product and use it as a site then I can see the extra IU for javase and I can install it without problems. So when running FeaturesAndBundlesPublisher followed by ProductPublisher we do get that. > I'm not sure, but I also heard that > sometimes people depend on "system.bundle" explicitly. But I'm not sure if it > was in that context. I tried that just to make sure and that does not insert an extra IU for javase into the content.xml generated by P2 via the UpdateSite Publisher I have read that the update site publisher was meant to generate "incomplete repositories that can be used in combination with other IUs". This would push towards supporting this enhancement in PDE itself. Thank you for your good analysis and description, Hugues. I also succeeded in using the "FeaturesAndBundlesPublisher"-Patch, but I needed feature categories, and therefore I started to patch the "UpdateSitePublisher". And when I opened the source code, I recognized that there is an (undocumented?? switch already, called "-addJREIU". So for everyone gooogleing and ending up here, here's a solution using that switch: 1.) Create features and plugins in the folder where you're side.xml resides just as usual (e.g. by using site.xml --> Build All). The created content.jar does not contain the JRE-IU. 2.) Run the Update-Site-Publisher with that site as source and add the parameter "-addJREIU": java -jar PATH_TO_ECLIPSE_361/plugins/org.eclipse.equinox.launcher_*.jar -addJREIU -application org.eclipse.equinox.p2.publisher.UpdateSitePublisher -metadataRepository file://TARGET_PATH -artifactRepository file://TARGET_PATH -source PATH_TO_SOURCE_SITE -compress -publishArtifacts In the target path you'll find the new content.jar, including the JRE-IU. Sorry for posting that solution here, but it was hardly to find out for me and this big is open and nearly untouched since more than 6 month. Readers please note: This bug is related to bug #313454. p2 has the notion of a JRE IU that describes the packages made available by the JRE. This is roughly equivalent to the content of the .profile files in the org.eclipse.osgi bundle. This is needed because some bundles import javax.* etc packages that ultimately come from the JRE. At runtime these are "supplied" by the framework but in p2 land we need an IU that says it supplies them. For any given provisioning operation at least one of the metadata repos involved needs provide the things that are being "required". Mostly that is a matter of publishing the bundles and features involved. For the JRE IU we supplied an (apparently undocumented) option -addJREIU that Holger points out (thanks). This will cause the JRE IU to be published into the destination repo. An alternative approach is to ensure that the provisioning operation has access to a repo that already has the JRE IU. For example, the Helios repo. Of course, that is not always convenient but it is key to understanding what's going on here. Sidenote: for category publishing there is a CategoryPublisherApplication you can use to add categories into a repo. Note also that categories do not need to be in the same repo as the things they categorize. When p2 runs it mashes together all the repo so the actual physical origins don't matter. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release. |