Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311780

Summary: Control+Y overwritten by SystemTap GUI
Product: [Tools] Linux Tools Reporter: Charley Wang <charley.wang>
Component: SystemtapAssignee: anithra <anithra>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: overholt, pmuldoon
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch for 311780 none

Description Charley Wang CLA 2010-05-05 14:59:30 EDT
This appears to occur off the install site as well as from trunk. 

When installed, the SystemTap plugin takes over the ctrl+Y key combination, which is used on many systems as a shortcut for 'Redo.' 

Reproduce:
Hit ctrl-Y with SystemTap installed in Eclipse -- get a box that says "Enter Script details"


Also, this dialog box does not go away when it is closed (it disappears when cancel is hit, but not with the 'x')

-Charley
Comment 1 Charley Wang CLA 2010-05-05 15:09:23 EDT
Created attachment 167209 [details]
Patch for 311780

Allows the CreateModuleAction dialog to close when the dialog is closed.

Also changes the hotkeys for Export Script and Create Module Action from "ctrl-X" and "ctrl-Y" to "ctrl-1" and "ctrl-2" respectively. The latter two actions do not appear to conflict with any major editing shortcut keys.
Comment 2 Andrew Overholt CLA 2010-05-05 15:21:02 EDT
Thanks for filing this, Charley.  I've been meaning to file it myself :)
Comment 3 Andrew Overholt CLA 2010-05-06 09:58:21 EDT
Don't use Ctrl-1 and Ctrl-2.  Ctrl-1 is the quick fix shortcut.  I don't know about Ctrl-2.  TBH I think a good quick fix for this is to not have any shortcuts for these action and to try to come up with something for 0.6.
Comment 4 Charley Wang CLA 2010-05-06 10:24:37 EDT
Commented out the shortcut keys.

ctrl-4 and ctrl-5 appear to be unused, ctrl-alt-x and ctrl-alt-y as well.
Comment 5 Andrew Overholt CLA 2010-05-06 10:44:38 EDT
Those are probably okay choices for 0.6 but let's leave it uncommented for 0.5.1.  Feel free to un-comment and change the shortcuts on trunk.  Thanks, Charley.
Comment 6 Charley Wang CLA 2010-05-06 11:28:47 EDT
(In reply to comment #5)
> Those are probably okay choices for 0.6 but let's leave it uncommented for
> 0.5.1.  Feel free to un-comment and change the shortcuts on trunk.  Thanks,
> Charley.

Sure! They are commented out on branch 0.5.0, and uncommented as ctrl+4 and ctrl+5 on trunk until further discussion.