Bugzilla – Full Text Bug Listing
| Summary: | [tcf] Patches for Symbian TCF agent porting support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] TCF | Reporter: | Ed Swartz <ed.swartz> | ||||||
| Component: | Core | Assignee: | Project Inbox <dsdp.tm.tcf-inbox> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | cdtdoug, eugene | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 0.3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
I have committed the patch, with few minor changes:
in trace.c:
removed RDEBUG_TRACE - it seems not needed since you can log to stderr if you call open_log_file("-") or use -L- option in the agent command line.
in mdep.c:
reused Windows/VxWorks implementation of pread/pwrite since it is identical to Symbian implementation.
in asyncreq.c:
req->error should be assigned before calling trace(), because the call can overwrite errno, also not sure why errno was printed two times, so I changed the code to print it only once.
Thanks.
(In reply to comment #1) > I have committed the patch, with few minor changes: > > in trace.c: > removed RDEBUG_TRACE - it seems not needed since you can log to stderr if you > call open_log_file("-") or use -L- option in the agent command line. This is fine for now -- but note that the (unspoken) benefit with that macro was that the trace could be "tee"'d to both stderr and to a file. But this support has been disabled for a while, so it's okay. > > in mdep.c: > reused Windows/VxWorks implementation of pread/pwrite since it is identical to > Symbian implementation. > > in asyncreq.c: > req->error should be assigned before calling trace(), because the call can > overwrite errno, also not sure why errno was printed two times, so I changed > the code to print it only once. Ok, that makes sense; thanks. Created attachment 167340 [details]
minor patch update
I realized when trying to build from a Linux host that we had an unnecessarily upper-cased #include in the Symbian mdep.h section. Could you apply this too?
(In reply to comment #3) > Created an attachment (id=167340) [details] > minor patch update > > I realized when trying to build from a Linux host that we had an unnecessarily > upper-cased #include in the Symbian mdep.h section. Could you apply this too? Done Thanks! Comment on attachment 167340 [details]
minor patch update
According to the discussion log, the patch update has also been applied, so marking as iplog+.
Bulk update: Marking all TCF fixes from the Helios period (2009-06-29 until 2010-06-01) as target 3.2 since they go through release review along with the TM 3.2 release. Moving bugs to new home for IP log. Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3 |
Created attachment 167163 [details] patches (via svn diff) against rev 943 We've been working on porting the reference TCF agent to Symbian. Attached are an initial set of patches against rev 943 needed to build for Symbian and Open C / PIPS. While most of the changes are localized to mdep.c/.h changes, there are a few extra trace() calls added which help us out in a tough-to-debug environment (discovery_udp.c, asynscreq.c). I hope they can be retained. Let me know if, on the other hand, a more specialized LOG_... selector should be used for these. I verified the agent still builds for Cygwin (my other readily available host environment). Note: our agent uses the TCF agent as a library, so the actual Symbian-specific implementation is outside these sources and not included in this patch. Thus, the patch will not allow you to build a full agent for Symbian. (Unfortunately, we won't be able to release sources for a full functioning agent since that would depend on proprietary internal APIs.) But it would be nice if we don't have to manually apply the attached changes when syncing against the upstream.