Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311748

Summary:

Update macosx Info.plist for export

Product:

[Eclipse Project] PDE

Reporter:

Andrew Niefer <aniefer>

Component:

Assignee:

Curtis Windatt <curtis.windatt.public>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public, darin.eclipse, remy.suen

Version:

3.6

Flags:

aniefer: review+

Target Milestone:

3.6 RC1

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Fix	none

Description Andrew Niefer

2010-05-05 10:53:29 EDT

Product export uses org.eclipse.pde.core/macosx/Info.plist on the mac if the delta pack is not present.

This file contains old versions  (3.3) and copyright information which should probably be updated.
Also we might want to add a CFBundleLocalizations key, see bug 242037 and org.eclipse.equinox.executable/bin/cocoa/macosx/x86/Eclipse.app/Contents/Info.plist

Comment 1 Curtis Windatt

2010-05-12 12:58:57 EDT

Created attachment 168199 [details]
Fix

Comment 2 Curtis Windatt

2010-05-12 13:00:13 EDT

Andrew, please review the patch.  I added the bundle localization key, everything looks reasonable, but I don't know what consequences adding the key could have.

Comment 3 Andrew Niefer

2010-05-12 17:10:14 EDT

See bug 242037 comment #29, mac translates the system portions of the menu based on the combination of language specific files under the Contents/Resources folder and the CFBundleLocalizations key in the Info.plist.

We decided to prepopulate with the list of language packs available in 3.2.x.  With bable, people translating for other languages would want to add their own language to the info.plist as well.

Patch looks good to me.

Comment 4 Curtis Windatt

2010-05-12 17:19:37 EDT

Fixed in HEAD.