Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311729

Summary:

Separate EE5/EE6 preferences for default DD generation

Product:

[WebTools] WTP Java EE Tools

Reporter:

Aidyl Kareh <amkareh>

Component:

jst.j2ee

Assignee:

Aidyl Kareh <amkareh>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

amkareh, david_williams, jsholl

Version:

unspecified

Flags:

david_williams: pmc_approved+
amkareh: pmc_approved? (raghunathan.srinivasan)
amkareh: pmc_approved? (naci.dai)
amkareh: pmc_approved? (deboer)
amkareh: pmc_approved? (neil.hauge)
amkareh: pmc_approved? (kaloyan)
cbridgha: review+
jsholl: review+

Target Milestone:

3.2 RC1

Hardware:

OS:

Windows Vista

Whiteboard:

PMC_approved

Bug Depends on:

Bug Blocks:

310163

Attachments:

Description	Flags
Patch	none
Updated Patch	none

Description Aidyl Kareh

2010-05-05 10:15:22 EDT

Build Identifier: WTP 3.2

Since Java EE6 makes deployment descriptor for web projects optional, WTP shouldn't generate them by default for them. However, Web 2.5 projects require deployment descriptors for most situations. Separate preferences should be defined for EE5 and EE6, where EE5's default value is to generate the DD and EE6's default value would be to not generate it. This would be a low risk change since the default EE5 behavior in the past was to create the DD by default.

Reproducible: Always

Comment 1 Aidyl Kareh

2010-05-05 10:18:40 EDT

Created attachment 167142 [details]
Patch

This patch adds a separate preference for EE6 and sets the default check state of the dd checkbox in dynamic web 3.0 project to off. This patch also changes the default check state of the dd checkbox in dynamic web 2.5 project to on.

Comment 2 Aidyl Kareh

2010-05-05 17:04:36 EDT

Created attachment 167237 [details]
Updated Patch

Updated patch so that the default behavior for Web 2.5 projects is still to not generate the DD but now the ProductManager class is used to set the default behavior. This patch continues to add a separate preference for EE6 and sets the default check state of the dd checkbox in dynamic web 3.0 project to off.

Comment 3 Chuck Bridgham

2010-05-06 15:01:05 EDT

approve

Comment 4 Aidyl Kareh

2010-05-06 17:21:10 EDT

* Explain why you believe this is a stop-ship defect. Or, if it is a
"hotbug" (requested by an adopter) please document it as such. 

The Web 2.5 default option for generating the deployment descriptors needs to be exposed for an adopter product.

    * Is there a work-around? If so, why do you believe the work-around is
insufficient? 

No

    * How has the fix been tested? Is there a test case attached to the
bugzilla record? Has a JUnit Test been added? 

Tested different possible scenarios during web project creation using the UI.

    * Give a brief technical overview. Who has reviewed this fix? 

The basic idea is to provide separate default options for web 2.5 and 3.0 when generating a DD. This patch also provides adopters the option to overwrite the ProductManager default value for web 2.5 projects. Chuck, and Jason have reviewed this patch.

    * What is the risk associated with this fix? 

I believe the risk is minimal since this patch is adding separate options but they are both remaining in their previous default value of not generating the web DD.

Comment 5 David Williams

2010-05-06 22:11:33 EDT

This is a tough one. Hard to sort out what is being done for ease of use, and what's being provided for adopter use. In either case, I can approve this for RC1, but it is a good example of an issue that would take more discussion after RC1. Good think you solved it this week. :)

Comment 6 Jason Sholl

2010-05-07 10:53:13 EDT

checked into head for 32 RC1