Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311722

Summary:	E4XMIResource's getUniqueId() is implemented incorrectly
Product:	[Eclipse Project] e4	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:	Remy Suen <remy.suen>
Severity:	normal
Priority:	P3
Version:	1.0
Target Milestone:	1.0 M6
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2010-05-05 09:48:21 EDT

private String getUniqueId() {
  String id = createId();
  while (objectMap.get(id) != null) {
    id = createId();
  }
  return id;
}

Here, 'objectMap' is a Map<EObject, String> but we use a String as a key. This is obviously wrong.

Comment 1 Remy Suen

2010-05-05 09:49:27 EDT

Thanks for catching this, Tom.