Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311684

Summary:

dependencies not revalidated when replacing a workspace query by a registered one

Product:

[Modeling] MoDisco

Reporter:

Nicolas Bros <nicolas.bros>

Component:

Infrastructure

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

gdupe, hugo.bruneliere, modisco.web-inbox

Version:

0.8.0

Flags:

nicolas.bros: helios+
hugo.bruneliere: review+

Target Milestone:

0.8.0

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

312456

Attachments:

Description	Flags
patch	none

Description Nicolas Bros

2010-05-05 05:36:01 EDT

- do "New > Example > Java Browser Customization"
- On this project, do "New > QuerySet model"
- Create a query set named "textJavaQueries.querySet"
- Error markers should appear
- Delete this query set
- Error markers don't disappear, you need to clean

Comment 1 Nicolas Bros

2010-05-11 11:26:46 EDT

When I remove this line:
MoDiscoResourceSet.getResourceSetSingleton().removeListener(this, rootObjectURI);
in AbstractMoDiscoCatalog.removeWSFile, the problem disappears and all unit tests pass.
But since you added it for a reason, I'll let you investigate further and decide how to best fix it.

Comment 2 Nicolas Bros

2010-05-12 12:59:08 EDT

Created attachment 168200 [details]
patch

In fact, the problem was due to listeners not being added when the referred resource couldn't be loaded (non valid file).
This patch fixes the problem by adding a listener in this case.
As a bonus, it also fixes Bug 312456!

Comment 3 Hugo Bruneliere

2010-05-17 04:21:47 EDT

Hi Nicolas,

You can go ahead with this patch.

Best regards,

Hugo

Comment 4 Nicolas Bros

2010-05-17 04:47:33 EDT

Thanks. I have applied the patch to branch 0_8_0.

Comment 5 Hugo Bruneliere

2010-10-01 13:37:01 EDT

Patch successfully committed.