Bugzilla – Full Text Bug Listing
| Summary: | ServerEditorOverviewPageModifier doesn't have a SWC | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | Angel Vera <arvera> | ||||
| Component: | wst.server | Assignee: | Angel Vera <arvera> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Angel Vera <arvera> | ||||
| Severity: | major | ||||||
| Priority: | P2 | Flags: | arvera:
pmc_approved?
(david_williams) arvera: pmc_approved? (raghunathan.srinivasan) arvera: pmc_approved? (naci.dai) deboer: pmc_approved+ arvera: pmc_approved? (neil.hauge) arvera: pmc_approved? (kaloyan) |
||||
| Version: | 3.2 | ||||||
| Target Milestone: | 3.2 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| See Also: | https://git.eclipse.org/r/108947 | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. Without this fix, the new extension point .ServerEditorOverviewPageModifier will not work correctly and adopter are not going to be able make full usage of this function * Is there a work-around? If so, why do you believe the work-around is insufficient? No workoarund. * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? I tested the fix by implementing a extension point that will use this function * Give a brief technical overview. Who has reviewed this fix? Refer to comment #0 * What is the risk associated with this fix? minimal, as this is a new extension point and it wasn't working correctly before. changes committed to HEAD Changes released to HEAD New Gerrit change created: https://git.eclipse.org/r/108947 |
Created attachment 166979 [details] v1.0 Browsing through the code, it seems that the original contribution of the ServerEditorOverviewPageModifier has a defect in where the ServerWorkingCopy within the PageMofifier is never set because fireServerWorkingCopyChanged is never called. But fireServerWorkingCopyChange perhaps shouldn't exist in the scope OverviewPage because the SWC will only change once during initialization from null to an actual value. I suggest we remove the fireServerWorkingCopyChanged method from the OverviewEditorPart and instead just set the SWC during initialization, as per the patch attached.