Bug 311575

Description Troy Bishop 2010-05-04 11:49:42 EDT

Build Identifier: 3.0.5 patches

The following code within org.eclipse.wst.server.ui.internal.wizard.TaskWizard#performFinish() assumes that any Exception that is thrown by the run() call is an error:

Throwable t = null;
try {
	if (getContainer() != null)
		getContainer().run(true, true, new WorkspaceRunnableAdapter(runnable));
	else
		runnable.run(new NullProgressMonitor());
	return true;
} catch (InvocationTargetException te) {
	Trace.trace(Trace.SEVERE, "Error finishing task wizard", te);
	t = te.getCause();
} catch (Exception e) {
	Trace.trace(Trace.SEVERE, "Error finishing task wizard 2", e);
	t = e;
}

If the Exception that is thrown is a java.lang.InterruptedException than a message is logged to the workspace .log file saying "Error finishing task wizard 2".  This is not correct as the logic that was executed was canceled so there was no error and no entry should exist in the .log file, like the following:


!MESSAGE Error finishing task wizard 2
!STACK 0
java.lang.InterruptedException
at org.eclipse.jface.operation.ModalContext.run(Unknown Source)
at org.eclipse.jface.wizard.WizardDialog.run(Unknown Source)
at org.eclipse.wst.server.ui.internal.wizard.TaskWizard.performFinish(Unknown Source)
at org.eclipse.jface.wizard.WizardDialog.finishPressed(Unknown Source) 
at org.eclipse.jface.wizard.WizardDialog.buttonPressed(Unknown Source)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Unknown Source)
at org.eclipse.swt.widgets.TypedListener.handleEvent(Unknown Source)
at org.eclipse.swt.widgets.EventTable.sendEvent(Unknown Source)
at org.eclipse.swt.widgets.Widget.sendEvent(Unknown Source)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Unknown Source)
at org.eclipse.swt.widgets.Display.readAndDispatch(Unknown Source)
at org.eclipse.jface.window.Window.runEventLoop(Unknown Source)
at org.eclipse.jface.window.Window.open(Unknown Source)
at org.eclipse.wst.server.ui.internal.view.servers.ModuleSloshAction.perform(Unknown Source)
...

Reproducible: Always