Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311558

Summary: [ui] labels for guard predicates are not beautified
Product: [Tools] Objectteams Reporter: Stephan Herrmann <stephan.herrmann>
Component: OTDTAssignee: Stephan Herrmann <stephan.herrmann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.4   
Target Milestone: 0.7 M2   
Hardware: Other   
OS: All   
Whiteboard:
Attachments:
Description Flags
fix none

Description Stephan Herrmann CLA 2010-05-04 10:19:15 EDT 
As of http://trac.objectteams.org/ot/ticket/179 the OTDT was able
to beautify the labels for guard predicates (no internal name, styling).
This was released for 1.2.5 but soon after broke again. I just checked 
1.3.2, where it is indeed broken.

A hint to the cause is found in http://trac.objectteams.org/ot/changeset/19982

The introducation of JavaElementLabelComposer was never fully adopted by
our ViewAdaptor.
Comment 1 Stephan Herrmann CLA 2010-05-04 10:41:34 EDT 
Created attachment 166961 [details]
fix

Fixed by moving trigger for callin beautifyGuardLabel: no longer intercept
method from JavaElementLabels but add a new role JavaElementLabelComposer,
adapting the same-named base class, which was introduced in 3.5.
This base class provides the real implementation for JavaElementLabels,
so adapting here provides for more consistency.
Comment 2 Stephan Herrmann CLA 2010-05-04 10:51:53 EDT 
Patch has been committed as r294.
Comment 3 Stephan Herrmann CLA 2010-06-02 18:15:39 EDT 
Post-hoc verified using M3.