Bugzilla – Full Text Bug Listing
| Summary: | ImportProjectSetAction should wrap importProjectSet in a WorkspaceModifyOp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | James Blackburn <jamesblackburn+eclipse> | ||||
| Component: | Team | Assignee: | Tomasz Zarna <tomasz.zarna> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 3.6 | ||||||
| Target Milestone: | 3.7 M1 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 321497 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Yup, it looks you're right. Thanks for the patch, I'll review it as soon as 3.6 is shipped. A polite ping on this :) Fixed in HEAD. Thanks for the patch James. Available in builds >=I20100802-1300. |
Created attachment 166943 [details] patch 1 The API usage on ProjectSetCapability#addToWorkspace(...) says: * Callers from within a UI context should wrapper a call to this method * inside a WorkspaceModifyOperation so that events generated as a result * of this operation are deferred until the outermost operation * has successfully completed. Unfortunately ImportProjectSetAction doesn't do this leading to very many resource change events being fired during a project set checkout using this action. (The operation ImportProjectSetOperation accessible via the import dialog does the right thing -- it's a TeamOperation which runs checked into the workspace.) Trivial patch attached.