Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311516

Summary: [Theme] OS-Specific of themes
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Thomas Schindl <tom.schindl>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: gheorghe
Version: 1.0   
Target Milestone: 1.0 M6   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Patch none

Description Thomas Schindl CLA 2010-05-04 07:42:06 EDT 
I'm not sure whether the current implementation of os and ws detection is a good one. We need to make it possible that we only have 1-Theme-Id and so I think the OS/WS contraint is not make sense 100% there. If we have them I think OS should allow at least to be:
* empty => applies to all OSes
* commaseparated => applies on to the given ones
Comment 1 Thomas Schindl CLA 2010-05-04 07:50:35 EDT 
checked in the proposed changes to CVS
Comment 2 Thomas Schindl CLA 2010-05-04 13:44:08 EDT 
Reopening to discuss variables in the Stylepath.
Comment 3 Thomas Schindl CLA 2010-05-04 13:45:42 EDT 
Created attachment 166990 [details]
Patch

Bogdan - what do you think does it make sense if we add variable substitution in the stylesheet path? This would allow us to define one theme with different basecss of different os, ...
Comment 4 Thomas Schindl CLA 2010-05-04 13:46:43 EDT 
the urls would look like this then: "$os-$ws$-dark.css"
Comment 5 Thomas Schindl CLA 2010-05-20 11:26:31 EDT 
I checked in the change which allows people to use $ws$ and $os$ in the style path
Comment 6 Bogdan Gheorghe CLA 2010-05-20 14:29:42 EDT 
Sorry I didn't get back to you earlier, I was out of the office for the last couple of weeks. 

I suppose a user might not care about os/ws, so having a way to opt out of it is OK with me. I think your variable substitution idea is good.