Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311474

Summary:

[debug view] Provide a default command handler for the Restart command.

Product:

[Eclipse Project] Platform

Reporter:

Pawel Piech <pawel.1.piech>

Component:

Debug

Assignee:

Pawel Piech <pawel.1.piech>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

darin.eclipse, remy.suen

Version:

3.6

Flags:

darin.eclipse: review+

Target Milestone:

3.6 RC1

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

289526

Attachments:

Description	Flags
Patch that adds the restart command handler.	none

Description Pawel Piech

2010-05-04 00:17:25 EDT

Created attachment 166901 [details]
Patch that adds the restart command handler.

The Restart action was added to the Debug view context menu with bug 286256.  It is visible only when the selected context adopts to IRestartHandler and it allows the selected process to be restarted without relaunching.  

The Restart action is available in the context menu and not in the top-menu so it is not accessible using keyboard only.  We only need to add a default command handler to enable the restart key binding to be used to activate the Restart command.

Comment 1 Pawel Piech

2010-05-04 00:19:38 EDT

I would like to target this for RC1.  Darin please approve?

Comment 2 Darin Wright

2010-05-04 12:29:55 EDT

+1 for RC1. However, should the handler extension be contributed as a "defaultHandler" on the command extension itself (rather than separately contriubuted to the handlers extension point).

@see TerminateAndRelaunchHandler as an example.

Comment 3 Pawel Piech

2010-05-04 13:09:44 EDT

(In reply to comment #2)
> +1 for RC1.
Thank you, Committed.

> However, should the handler extension be contributed as a
> "defaultHandler" on the command extension itself (rather than separately
> contriubuted to the handlers extension point).
> 
> @see TerminateAndRelaunchHandler as an example.
Good point.  Functionally it makes no difference, but the use of defaultHandler makes the XML a little cleaner.

Comment 4 Darin Wright

2010-05-04 15:13:15 EDT

Verified.