Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311468

Summary: JUnit failure: ErrorParserFileMatchingTest - SymbolicLink, intermittent
Product: [Tools] CDT Reporter: Andrew Gvozdev <angvoz.dev>
Component: cdt-buildAssignee: cdt-build-inbox <cdt-build-inbox>
Status: RESOLVED WORKSFORME QA Contact: Andrew Gvozdev <angvoz.dev>
Severity: normal    
Priority: P3 CC: jamesblackburn+eclipse
Version: 7.0   
Target Milestone: 7.0   
Hardware: All   
OS: All   
Whiteboard:

Description Andrew Gvozdev CLA 2010-05-03 22:38:02 EDT 
The failure happens intermittently during Hudson builds:

build #105:
org.eclipse.cdt.core.internal.errorparsers.tests.ErrorParserFileMatchingTest.testFolderSymbolicLink  (from ErrorParserFileMatchingTest) 
Error Message null

Stacktrace
junit.framework.AssertionFailedError: null
	at org.eclipse.cdt.core.testplugin.ResourceHelper.createSymbolicLink(ResourceHelper.java:549)
	at org.eclipse.cdt.core.internal.errorparsers.tests.ErrorParserFileMatchingTest.testFolderSymbolicLink(ErrorParserFileMatchingTest.java:494)
	at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:376)

build #106:
org.eclipse.cdt.core.internal.errorparsers.tests.ErrorParserFileMatchingTest.testDuplicateFolderSymbolicLink  (from ErrorParserFileMatchingTest)

Error Message
null

Stacktrace
junit.framework.AssertionFailedError: null
	at org.eclipse.cdt.core.testplugin.ResourceHelper.createSymbolicLink(ResourceHelper.java:549)
	at org.eclipse.cdt.core.internal.errorparsers.tests.ErrorParserFileMatchingTest.testDuplicateFolderSymbolicLink(ErrorParserFileMatchingTest.java:517)
	at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:376)
Comment 1 Andrew Gvozdev CLA 2010-05-13 11:08:53 EDT 
Fix committed on HEAD. Let me see for a few builds if it works reliably.
Comment 2 James Blackburn CLA 2010-05-13 11:37:42 EDT 
I tweaked your fix Andrew as this test always fails for me here.

You shouldn't assert that the main thread isn't interrupted.  Anyone's allowed to interrupt any thread at any time, and the platform's cancellable progress monitor interrupts the UI thread frequently -- this allows it to perform asyncExecs while the waiting for locks on the UI thread, thereby preventing many deadlock situations.
Comment 3 Andrew Gvozdev CLA 2010-05-13 11:54:40 EDT 
OK, I had a thought that we might need a loop like that.
Comment 4 Andrew Gvozdev CLA 2010-05-14 14:53:19 EDT 
This issue is likely resolved, it was not there in latest builds. Closing.
Comment 5 Andrew Gvozdev CLA 2010-06-04 00:37:05 EDT 
Appeared again in nightly build http://download.eclipse.org/tools/cdt/builds/7.0.0/I.I201006031133/junits.html:

null expected:<[L/FindMatchingFilesTest/FolderSymbolicLink/testFolderSymbolicLink.c]>  but was:<[P/FindMatchingFilesTest]>

junit.framework.ComparisonFailure: null expected:<[L/FindMatchingFilesTest/FolderSymbolicLink/testFolderSymbolicLink.c]> but was:<[P/FindMatchingFilesTest]>
at org.eclipse.cdt.core.internal.errorparsers.tests.ErrorParserFileMatchingTest.testFolderSymbolicLink(ErrorParserFileMatchingTest.java:504)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:376)
Comment 6 Andrew Gvozdev CLA 2010-07-15 13:06:29 EDT 
Same in Hudson build#258:

junit.framework.ComparisonFailure: null expected:<[L/FindMatchingFilesTest/FolderSymbolicLink/testFolderSymbolicLink.c]> but was:<[P/FindMatchingFilesTest]>
	at org.eclipse.cdt.core.internal.errorparsers.tests.ErrorParserFileMatchingTest.testFolderSymbolicLink(ErrorParserFileMatchingTest.java:504)
	at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:376)
Comment 7 CDT Genie CLA 2010-07-28 15:26:16 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 311468: JUnit failure: ErrorParserFileMatchingTest - SymbolicLink, intermittent
tweak to test with Hudson build

[*] ResourceHelper.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/ResourceHelper.java?root=Tools_Project&r1=1.4&r2=1.5
Comment 9 CDT Genie CLA 2010-07-28 15:26:49 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 311468: JUnit failure: ErrorParserFileMatchingTest - SymbolicLink
More investigative asserts added

[*] ResourceHelper.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/ResourceHelper.java?root=Tools_Project&r1=1.7&r2=1.8
Comment 10 CDT Genie CLA 2010-07-28 15:27:07 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 311468: JUnit failure: ErrorParserFileMatchingTest - SymbolicLink
More detailed message in case of interruption

[*] ResourceHelper.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/ResourceHelper.java?root=Tools_Project&r1=1.8&r2=1.9
Comment 11 CDT Genie CLA 2010-07-28 15:27:13 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 311468: JUnit failure: ErrorParserFileMatchingTest - SymbolicLink
one more check

[*] ResourceHelper.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/ResourceHelper.java?root=Tools_Project&r1=1.9&r2=1.10
Comment 13 Andrew Gvozdev CLA 2011-03-15 14:27:14 EDT 
It still happens occasionally even if pretty rare. Hudson #580:

null expected:<[P/FindMatchingFilesTest]> but was:<[L/FindMatchingFilesTest/FolderSymbolicLinkA/testDuplicateFolderSymbolicLink.c]>
junit.framework.ComparisonFailure: null expected:<[P/FindMatchingFilesTest]> but was:<[L/FindMatchingFilesTest/FolderSymbolicLinkA/testDuplicateFolderSymbolicLink.c]>
	at org.eclipse.cdt.core.internal.errorparsers.tests.ErrorParserFileMatchingTest.testDuplicateFolderSymbolicLink(ErrorParserFileMatchingTest.java:529)
	at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:416)
	at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:249)
	at org.eclipse.test.UITestApplication$2.run(UITestApplication.java:197)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3524)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3173)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2697)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2661)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2495)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:140)
	at org.eclipse.test.UITestApplication.run(UITestApplication.java:62)
	at org.eclipse.test.UITestApplication.start(UITestApplication.java:212)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.equinox.internal.app.MainApplicationLauncher.run(MainApplicationLauncher.java:32)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
	at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 14 Andrew Gvozdev CLA 2012-08-25 12:03:35 EDT 
Haven't seen that for quite a while.