Bugzilla – Full Text Bug Listing
| Summary: | TVT36:TCT108: CHS: Button Truncated | ||
|---|---|---|---|
| Product: | [Tools] Data Tools | Reporter: | CDE Administration <cdeadmin> |
| Component: | SQLDevTools | Assignee: | Brian Payton <bpayton> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bpayton, camle, kitlo |
| Version: | 1.8 | ||
| Target Milestone: | 1.8 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| URL: | 108 | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
CDE Administration
Created attachment 166832 [details]
108_08.000.500_truncation.gif
Created attachment 166833 [details]
TCT#108_08.000.500_truncation.gif
Created attachment 166834 [details]
08.000.500.gif
Created attachment 166835 [details]
TCT108_TruncatedBox.gif
Created attachment 166836 [details]
TCT108_TruncatedBox.gif
Created attachment 166837 [details]
08.000.500.png
<cde:tctdetail> Testcase: 08.000.500 - DTP - RESULT SET VIEWER OPTIONS PAGE Project: WSW36 Component: Xfer - Data Tools/Data Source Explorer Priority: 2 Subject: CHS: Button Truncated Article ID: 108 Originator: maxl@szchkj.com.cn </cde:tctdetail> <response_by> rewagner at 2010.05.03.16.41.05 </response_by> Changing status to working <response_by> Katia Milekhina at 2010.05.04.02.36.06 </response_by> Same problem for Russia. Regards, Katia <response_by> Kathy Li at 2010.05.04.13.06.17 </response_by> Must-Fix: Yes I can't reproduce this problem. I used the Babel Pseudo Translation to get long text values (that I could still read) but I didn't see any truncation for the fields reported in this defect. Next I hacked the pseudo translation to make the text values even longer, and the fields still expand properly to show the entire string. I am attaching an image showing the fields properly expanded with the extra long text values. Created attachment 167851 [details]
Image showing SQL Results View preference page with long text values but no truncation
Created attachment 167854 [details]
SQLResultsViewerOptionsTrunction.gif
The layout control for these controls does not specify a width, and the combo
control is free to grab excess space. Here's the code that creates the result
set viewer label and combo box:
GridData gridData = new GridData(GridData.FILL_HORIZONTAL);
gridData.horizontalSpan=2;
resultViewersGroup.setLayoutData(gridData);
GridLayout gLayout = new GridLayout();
gLayout.numColumns = 2;
resultViewersGroup.setLayout(gLayout);
Label label = new Label(resultViewersGroup, SWT.NONE);
label.setText(Messages.ResultSetViewerPage_select_viewer);
viewersCombo = new Combo(resultViewersGroup, SWT.DROP_DOWN |
SWT.READ_ONLY);
viewersCombo.setToolTipText(Messages.ResultSetViewerPage_viewer_tooltip);
GridData comboData = new GridData();
comboData.grabExcessHorizontalSpace = true;
viewersCombo.setLayoutData(comboData);
If a SWT/JFace expert can point whether this code is doing something wrong, I'd
appreciate it.
Please reopen if you can help me understand why the layout truncates for one language but not another with much longer text value length. Attachment added by CDE Attachment added by CDE <response_by> Kathy Li at 2010.05.11.11.24.16 </response_by> I have tried to use I20100429-1549(NL Build version : 20100509-1500-nl1). I still see truncation in CHS. Please continue to investigate as this is listed as must-fix and it happens to quite a few countries. If needed, you are welcome to use one of TVT English server with MUI for this test. Please ping me for machine information. thanks Kathy Created attachment 168086 [details]
new ResultSetViewerPreferencePage.java
Brian, I don't have connection to the DTP repository. I didn't create a patch. But, this seems to resolve the truncation problem. Please review.
Created attachment 168087 [details]
screen capture
Here are the pictures (in French) before and after the fix.
Attachment added by CDE Reopening, since we have a new proposed fix. Created attachment 168243 [details]
Patch for o.e.d.sqltools.result.ui
I tested Kit's code, and it looks like it works fine. I have created and attached a patch. Checked in fix, tagged to v201005130345. Thanks Kit! Attachment added by CDE Attachment added by CDE Attachment added by CDE Attachment added by CDE Attachment added by CDE Attachment added by CDE <response_by> Ma Xiao Long at 2010.05.20.01.55.45 </response_by> Fixed fo CHS in build 20100518-2000-nl1, thanks! Attachment added by CDE Attachment added by CDE <response_by> martine marin at 2010.05.20.03.57.40 </response_by> Fixed for France Verified in buid 20100519-1300 Thanks a lot, Martine Attachment added by CDE Attachment added by CDE <response_by> Manuel Ferro at 2010.05.21.10.16.11 </response_by> It's fine, for portuguese, in build 20100520-0200 Regards, Ricardo Attachment added by CDE <response_by> Lisa Chang at 2010.05.26.23.09.11 </response_by> fixed in build 20100518-2000-nl1 for CHT Attachment added by CDE Attachment added by CDE <response_by> maria cristina caroletti at 2010.05.31.05.00.10 </response_by> Hi It's fixed, for italian, in build 20100529-2200 Regards, Alessandro Attachment added by CDE <response_by> Emilio Cifuentes at 2010.05.31.06.19.45 </response_by> Hi Fixed for spanish. Thanks Emilio Attachment added by CDE |