Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311330

Summary: [planner] Strict negation not taken into account when the IU is patched
Product: [Eclipse Project] Equinox Reporter: Pascal Rapicault <pascal>
Component: p2Assignee: Daniel Le Berre <leberre>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 Flags: pascal: review+
Version: 3.6   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard: stalebug
Attachments:
Description Flags
Simple fix for that bug none

Description Pascal Rapicault CLA 2010-05-02 22:28:15 EDT 
I20100429
When an IU is patched and it originally contained a strict negation, the strict negation is not encoded.
This is because the code expandRequirementsWithPatches does not encode negation, it does not check for getMax() == 0.
Comment 1 Pascal Rapicault CLA 2010-05-02 22:33:11 EDT 
I have released the disabled test case: Bug311330
Comment 2 Pascal Rapicault CLA 2010-05-02 23:07:23 EDT 
Note that in this test case the problem of the encoding happens when we are encoding the top level IU (createMustHave).
Comment 3 Daniel Le Berre CLA 2010-05-03 17:43:46 EDT 
Created attachment 166876 [details]
Simple fix for that bug

Here is a simple fix for that bug.

It only works when the strict negation is not touched by the patch. 

To be complete, we should have test cases with:
- a patch that introduces a negation
- a patch that removes a negation

The patch also contains a typo fix in a comment :)
Comment 4 Pascal Rapicault CLA 2010-05-07 11:05:57 EDT 
I have released this patch in HEAD. But I'll leave this bug open so we can later deal with the other cases that Daniel mentions in the previous comment.
Comment 5 Eclipse Genie CLA 2019-03-11 03:44:11 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Lars Vogel CLA 2019-10-08 10:46:39 EDT 
This bug was marked as stalebug a while ago. Marking as wontfix.

If this report is still relevant for the current release, please
reopen and remove the stalebug whiteboard tag.