Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311300

Summary:

"cannot parse uri-ish" pushing to / fetching from for relative paths

Product:

[Technology] JGit

Reporter:

Chris West (Faux) <eclipse>

Component:

JGit

Assignee:

Christian Halstrick <christian.halstrick>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

caniszczyk, schoenbach, stefan.lay

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows Vista

Whiteboard:

Attachments:

Description	Flags
Patch with testcase	none

Description Chris West (Faux)

2010-05-01 20:52:43 EDT

Build Identifier: I20100413-1521

git allows remotes to be relative paths:

> git --version
git version 1.7.0.2.msysgit.0

> git remote -v
foo     ..\foo (fetch)
foo     ..\foo (push)
origin  git://git.foo.com/foo.git (fetch)
origin  git://git.foo.com/foo.git (push)

This makes sense.

This causes EGit's "Fetch from" and "Push to" commands to present an error dialog:
Corrupted Configuration
Remote repositories URIs configuration is corrupted.
Reason:
Cannot parse Git URI-ish: ../foo.

No stack-trace is available.

Reproducible: Always

Steps to Reproduce:
1. Add a relative remote: git remote add rel ../rel
2. On the associate project, Team -> Push To...
3. See error.

Comment 1 Chris West (Faux)

2010-05-02 13:03:08 EDT

Retested in 0.8.0.201004301514, still present.

Comment 2 Chris West (Faux)

2010-09-08 20:18:29 EDT

Created attachment 178467 [details]
Patch with testcase

Fix inside jgit's URIish "parser".

Comment 3 Chris Aniszczyk

2010-09-09 09:11:45 EDT

Chris F., can you contribute this via Gerrit?

http://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches

Thanks for the patch!

Comment 4 Chris West (Faux)

2010-09-09 14:24:38 EDT

Done, I think that took longer than writing the patch. ;p

http://egit.eclipse.org/r/#change,1575


(Also, I went for bugzilla because I foolishly read the SUBMITTING_PATCHES document: http://egit.eclipse.org/w/?p=jgit.git;a=blob;f=SUBMITTING_PATCHES;hb=HEAD )

Comment 5 Christian Halstrick

2010-10-08 07:02:02 EDT

this can be closed, or?

Comment 6 Robin Rosenberg

2011-01-01 20:09:51 EST

*** Bug 290840 has been marked as a duplicate of this bug. ***