Bugzilla – Full Text Bug Listing
| Summary: | Unregistered listener exception changing joining strategy from mappedBy to joinColumns | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Dali JPA Tools | Reporter: | Karen Butzke <karenfbutzke> | ||||||
| Component: | General | Assignee: | Karen Butzke <karenfbutzke> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | david_williams, neil.hauge, paul.fullbright | ||||||
| Version: | 2.3 | Flags: | david_williams:
pmc_approved+
neil.hauge: pmc_approved? (raghunathan.srinivasan) neil.hauge: pmc_approved? (naci.dai) neil.hauge: pmc_approved? (deboer) neil.hauge: pmc_approved? (neil.hauge) neil.hauge: pmc_approved? (kaloyan) neil.hauge: review+ |
||||||
| Target Milestone: | 2.3 RC1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | PMC_approved | ||||||||
| Attachments: |
|
||||||||
Created attachment 167221 [details]
proposed patch against head
The attached patch changes the UI to not call the unset*strategy() API when a radio button is deselected. A deselected radio button means that another radio button was selected. Thus this code is redundant and is causing problems. I think we should also remove the unset*strategy() API, but that can wait until the next release. I added TODO comments to that API and will enter another bug as a reminder.
I do not see the stack trace with the patch applied. Paul has reviewed this patch and agrees with the change. This is also how we approached the DerivedIdentity radio buttons where the model follows the same pattern. * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. At first I didn't think this bug merited inclusion in RC1, but after digging deeper found that this is a race condition that can have undetermined results, some worse than others, and some perhaps unknown. The bug also results in a flaky looking UI in this case. * Is there a work-around? If so, why do you believe the work-around is insufficient? N/A * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Multiple devs have tested this fix. * Give a brief technical overview. Who has reviewed this fix? See comment #1. Paul and I have reviewed the fix. * What is the risk associated with this fix? Low risk. Checked in to HEAD. Entered bug 311945 to remove the appropriate provisional API in the next release. verified fixed in build WTP-I-3.2.0-20100507065327 |
Created attachment 166694 [details] exception stack trace Start with the following Entity and select the foo mapping. In the JPA Details view change the joining strategy from 'mapped by' to 'join columns' and you will get the attached stack trace. @Entity public class Foo { @OneToMany(mappedBy = "") private String foo; }