Bugzilla – Full Text Bug Listing
| Summary: | [commands][cdi] MITargetSelect is too restrictive | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Nobody - feel free to take it <nobody> | ||||||||
| Component: | cdt-debug-dsf-gdb | Assignee: | Nobody - feel free to take it <nobody> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Marc Khouzam <marc.khouzam> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | pawel.1.piech | ||||||||
| Version: | 7.0 | Flags: | nobody:
iplog-
|
||||||||
| Target Milestone: | 7.0 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Looks good to me. The API tooling gave me an error if I didn't change the @since to 3.0 Created attachment 166740 [details]
Updated patch.
Updated @since tag. (In reply to comment #2) > Created an attachment (id=166740) [details] > Updated patch. Seems identical to the previous one :-) Created attachment 166776 [details]
Take two (or three)
Almost did it again. Sorry Marc. (In reply to comment #6) > Almost did it again. Sorry Marc. :-) Looks great. Committed to the HEAD. *** cdt cvs genie on behalf of mkhodjai *** Bug 311219 - [commands][cdi] MITargetSelect is too restrictive. [*] CommandFactory.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java?root=Tools_Project&r1=1.5&r2=1.6 [*] MITargetSelect.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetSelect.java?root=Tools_Project&r1=1.3&r2=1.4 |
Created attachment 166649 [details] Makes the generic constructor public and modifies CommandFactory. Currently MITargetSelect implementation is restricted to some specific cases. It is possible to subclass it, but the subclassing requires a new CommandFactory which requires a new IGDBControl implementation, etc. The attached patch simply changes the protected constructor of MITargetSelect and adds a new factory method to CommandFactory. Again not sure what to do with the "since" tag. It is set to 2.0, should I cahnge it for 3.0?