Bugzilla – Full Text Bug Listing
| Summary: | Regression in ProjectReferenceWizardFragment.getAvailableProjects(etc) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Common Tools | Reporter: | Carl Anderson <ccc> | ||||
| Component: | wst.common | Assignee: | Rob Stryker <stryker> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Carl Anderson <ccc> | ||||
| Severity: | major | ||||||
| Priority: | P2 | CC: | cbridgha, david_williams, stryker | ||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
stryker: pmc_approved? (raghunathan.srinivasan) stryker: pmc_approved? (naci.dai) stryker: pmc_approved? (deboer) stryker: pmc_approved? (neil.hauge) stryker: pmc_approved? (kaloyan) cbridgha: review+ ccc: review+ |
||||
| Target Milestone: | 3.2 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | PMC_approved | ||||||
| Bug Depends on: | 310873 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Carl Anderson
Assigning to Chuck for initial investigation. Um... I've updated from CVS and I cannot replicate this. Admittedly I just created a Dynamic web and an EAR and when i open the ear's module assembly page, the War shows. Then I try to add a new Project Reference, and the Web project does *not* show. So where is the error? Interesting. When I add the EJB project and client, all 4 show up in the wizard. ProjectReferenceWizardFragment.getAvailableProjects(etc) is coded incorrectly. Created attachment 166748 [details]
Patch to fix the logic
request approval for logic fix Approved - thanks - this regression was rushed in - last minute... these fixes clean up the logic. Carl: I already committed this, but I accidentally got the wrong approval. I should have been seeking yours. I apologize. Please either give your approval or instruct me to revert the patch. I've backed out the commit. We are after m7 and require PMC approvals, which I obviously forgot. Also Carl needs to approve of this. Seeking PMC now, not to try to pre-empt Carl's approval but realizing we are working on a tightened schedule. Since Chuck already approved of the fix, I expect Carl will as well. So just trying to grab approvals a little quicker. PMC approval conditional on Carl's approval would be appreciated. I approve of this patch. Looking at CVS, Rob reverted his "not yet approved" commit. Rob, since we are now in RC1, the person submitting this for PMC approval needs to answer the questions in http://wiki.eclipse.org/WTP_PMC_Defect_Review , in the "How To Prepare a PMC Defect Candidate" section. Since I am familiar with this bug, and want the fix in as soon as possible, I will attempt to do so: This is a bad bug- it allows for multiple references to the same child module to be added, which can really mess things up at deploy time. The workaround here would be for the user to go through the list manually and make sure that there is only one instance of each module added, but that is an unrealistic workaround- it would be far better to prevent the user from adding a reference more than once in the first place. This fix has been tested by hand by Rob, Chuck and myself. As Rob stated in comment #4, ProjectReferenceWizardFragment.getAvailableProjects() was not terminating its iteration through the list of existing projects when it should have. The risk is limited to the Deployment Assembly page, and it is a relatively safe fix. I think I'd need to make a boolean table to know if you got all the ands and nots correct, but will take your word on it. :) dropped to head |