Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311187

Summary:

Capitalize context action item 'Generate Java bean skeleton'

Product:

[WebTools] WTP Webservices

Reporter:

Georgi Hristov <georgi.hristov>

Component:

jst.ws

Assignee:

Mark Hutchinson <mahutch>

Status:

CLOSED FIXED

QA Contact:

Keith Chong <keith.chong.ca>

Severity:

trivial

Priority:

CC:

kaloyan

Version:

unspecified

Flags:

keith.chong.ca: pmc_approved? (david_williams)
keith.chong.ca: pmc_approved? (raghunathan.srinivasan)
keith.chong.ca: pmc_approved? (naci.dai)
deboer: pmc_approved+
keith.chong.ca: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
keith.chong.ca: review+

Target Milestone:

3.2 RC2

Hardware:

OS:

Windows Vista

Whiteboard:

PMC_approved

Attachments:

Description	Flags
patch	none
updated patch	keith.chong.ca: iplog+

Description Georgi Hristov

2010-04-30 10:28:05 EDT

Build Identifier: 20100211202452

The label should be capitalized and read "Generate Java Bean 
Skeleton", not "Generate Java bean skeleton".


Reproducible: Always

Steps to Reproduce:
1. Import a wsdl
2. Right-click on it and go to Web Services action item group
3. You may see the action 'Generate Java bean skeleton' which is not capitalized

Comment 1 Mark Hutchinson

2010-05-13 10:35:18 EDT

Created attachment 168388 [details]
patch

Comment 2 Keith Chong

2010-05-13 11:50:22 EDT

The actions do not follow Eclipse UI guidelines.

Mark has found two other strings that need to be updated:

Create Web service -> Create Web Service
Publish WSDL file -> Publish WSDL File

Comment 3 Keith Chong

2010-05-13 12:18:04 EDT

1. Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

Although not a stop-ship bug, submitting for PMC approval since it is a very simple and safe change to 3 strings.  The capitalization of the action label should follow conventions and be consistent with other actions in the menu.

2. Is there a work-around? If so, why do you believe the work-around is insufficient? 
No workaround

3. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

4. Give a brief technical overview. Who has reviewed this fix? 
UI CHANGE in terms of changing the resource string.  I've reviewed the fix.

5. What is the risk associated with this fix? 
Low risk.  Just a resource change.

Comment 4 Kaloyan Raev

2010-05-13 12:27:05 EDT

The word "skeleton" in the attached patch is still not capitalized.

Comment 5 Mark Hutchinson

2010-05-13 12:40:45 EDT

Created attachment 168414 [details]
updated patch

Oops, I must not have had my coffee yet.

Comment 6 Kaloyan Raev

2010-05-13 12:48:19 EDT

Looks good now. 
However, this is still targeted to RC1, which is under final test today and will be officially declared tomorrow. I guess you don't want to have a respin just for this change, and you would rather submit it for RC2?

Comment 7 Keith Chong

2010-05-13 12:55:06 EDT

Good catch.  Retargetting to RC2.

Comment 8 Keith Chong

2010-05-14 13:42:56 EDT

Released for RC2.

Comment 9 Mark Hutchinson

2010-06-17 14:40:59 EDT

Verified.