Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311165

Summary:	[ConcreteSyntaxValidator] Verify EDatatypes and EEnumLiterals
Product:	[Modeling] TMF	Reporter:	Moritz Eysholdt <moritz.eysholdt>
Component:	Xtext	Assignee:	Project Inbox <tmf.xtext-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	sebastian.zarnekow
Version:	1.0.0	Flags:	moritz.eysholdt: indigo+
Target Milestone:	SR2
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:
Bug Depends on:	333986, 333976
Bug Blocks:

Description Moritz Eysholdt

2010-04-30 08:45:26 EDT

The fix of bug 310435 causes the serializer to fail when the value for a terminal-, datatype-, or enum-rule is invalid. Before the fix, the value was just written to the output stream without any complaints.

Since the ConcreteSyntaxValidator is in a position to compose much more meaningful error messages for this kind of errors, it should do so.

Comment 1 Moritz Eysholdt

2011-01-11 10:06:06 EST

this is proposed to be handled bug 333976.

Comment 2 Moritz Eysholdt

2011-10-18 04:09:01 EDT

In the new serializer
- ValueSerializer.serializeAssignedValue() raises errors for invalid values of Terminal/Datatype-Rules.
- EnumLiteralSerializer.serializeAssignedEnumLiteral() raises error is an invalid enum rule literal is used.
In contrast to the old serializer, this error will be propagated back to whoever invoked the serializer and *not* cause another iteration in backtracking (at least when no backtracking-decision depends on it).

Comment 3 Karsten Thoms

2017-09-19 16:58:44 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 4 Karsten Thoms

2017-09-19 17:10:00 EDT

Closing all bugs that were set to RESOLVED before Neon.0