Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311116

Summary:

[Outline] Regression: Outline nodes with EObject#toString() as label

Product:

[Modeling] TMF

Reporter:

Sebastian Zarnekow <sebastian.zarnekow>

Component:

Xtext

Assignee:

Project Inbox <tmf.xtext-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

clay

Version:

1.0.0

Flags:

sebastian.zarnekow: helios+

Target Milestone:

RC1

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
proposed patch	none

Description Sebastian Zarnekow

2010-04-29 17:11:31 EDT

The default implementation of the EObjectLabelProvider will delegate to an AdapterFactoryLabelProvider if the EObject has no customized text(..) method and no name-Feature. The AdapterFactoryLabelProvider in turn will invoke toString() on the object, if no specific provider is available. This renders the default outline basically unusable for non trivial languages, e.g. even the outline of the Domainmodel contains nodes for TypeRefs labeled "org.eclipse.xtext.example....TypeRefImpl@012345".

Comment 1 Sebastian Zarnekow

2010-04-29 17:13:06 EDT

Proposed solution: Find a way to identify unreadable default labels and let consumeNode(..) return false for these objects.

Comment 2 Michael Clay

2010-05-06 15:58:31 EDT

Created attachment 167381 [details]
proposed patch

Comment 3 Michael Clay

2010-05-06 15:59:10 EDT

fixed in HEAD. pls verify

Comment 4 Karsten Thoms

2017-09-19 15:58:12 EDT

Closing bug which were set to RESOLVED before Eclipse Neon.0.