Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311102

Summary: [LRParser] LR parser test failures caused by miscast
Product: [Tools] CDT Reporter: Charley Wang <charley.wang>
Component: cdt-coreAssignee: Project Inbox <cdt-core-inbox>
Status: RESOLVED WORKSFORME QA Contact: Doug Schaefer <cdtdoug>
Severity: normal    
Priority: P3 CC: jamesblackburn+eclipse
Version: 7.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch for LR Tests none

Description Charley Wang CLA 2010-04-29 15:51:30 EDT
The proposed patch fixes some errors in the LR Parser tests that have been showing up in the Hudson build.

Tests:
org.eclipse.cdt.core.lrparser.tests.LRTests.testDesignatedInitializers 
org.eclipse.cdt.core.lrparser.tests.LRTests.testMoregetDeclarationsInAST1 
org.eclipse.cdt.core.lrparser.tests.LRTests.testMoregetDeclarationsInAST2 
org.eclipse.cdt.core.lrparser.tests.LRTests.testMoregetDeclarationsInAST3 

were failing with miscasts (from CASTInitializerList -> IASTEqualsInitializer)

Patch is applied to AST2Tests, which LRTests extends. It also should not  adversely affect the AST2Tests. 

The patch just adds a function to do some quick type checking and handles an object appropriately.

-Charley
Comment 1 Charley Wang CLA 2010-04-29 15:52:14 EDT
Created attachment 166562 [details]
patch for LR Tests

Attached patch.
Comment 2 James Blackburn CLA 2011-01-22 06:41:00 EST
These tests are no longer failing, though there are a bunch of lrparser failures:
https://hudson.eclipse.org/hudson/job/cdt-nightly/lastCompletedBuild/testReport/