Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311097

Summary:

[NLS] validation builder job uses incorrect message

Product:

[WebTools] WTP Common Tools

Reporter:

Karen Butzke <karenfbutzke>

Component:

wst.validation

Assignee:

Wini Mark <wmmark>

Status:

CLOSED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc, david_williams, karasiuk, valentinbaciu

Version:

3.1

Flags:

david_williams: pmc_approved+
ccc: pmc_approved? (raghunathan.srinivasan)
ccc: pmc_approved? (naci.dai)
ccc: pmc_approved? (deboer)
ccc: pmc_approved? (neil.hauge)
ccc: pmc_approved? (kaloyan)
karasiuk: review+
ccc: review+

Target Milestone:

3.2 RC1

Hardware:

OS:

Windows XP

Whiteboard:

PMC_approved

Attachments:

Description	Flags
Fix the message	valentinbaciu: iplog+

Description Karen Butzke

2010-04-29 15:10:44 EDT

When the Validation builder job runs the progress monitor displays:
Validation [project_name]
instead of:
Validating [project_name]

Comment 1 Valentin Baciu

2010-04-29 15:23:34 EDT

Hi Karen, is this the same behaviour described in bug 308541?

*** This bug has been marked as a duplicate of bug 308541 ***

Comment 2 Karen Butzke

2010-04-29 15:27:29 EDT

Nope, this is a different message, I am using today's Ibuild in testing this.  The code I am looking at is line 164 of ValBuildJob:

setName(ValMessages.JobName + " " + request.getProject().getName()); //$NON-NLS-1$

ValMessages.JobName is Validation, which is fine for the Job name.

Comment 3 Valentin Baciu

2010-04-29 15:43:18 EDT

Thanks Karen, let's see if we can get this fix in for M7.

Wini, I think it would be even better to have message with parameter instead of using string concatenation there.

Comment 4 Wini Mark

2010-04-29 16:37:42 EDT

Created attachment 166569 [details]
Fix the message

Comment 5 Wini Mark

2010-04-29 17:07:12 EDT

Talked to Carl and it's too late for M7. We will fix it in RC1.

Comment 6 Carl Anderson

2010-05-03 10:33:19 EDT

Requesting PMC approval for WTP 3.2 RC1 for this additional string.
There's no workaround here - we are just using a new string to correctly aggregate the message content as well as properly fix the grammar used.
This has been tested by hand.  Since it is a simple string fix, there is no JUnit test.  Gary Karasiuk and myself have reviewed the fix.  This is an extremely low risk fix.

Comment 7 David Williams

2010-05-03 11:17:22 EDT

I think this is worth it (frequently seen, low risk).

Comment 8 Valentin Baciu

2010-05-06 15:00:08 EDT

Carl, please commit and release (Wini is not a committer).

Comment 9 Carl Anderson

2010-05-06 21:36:03 EDT

Committed to HEAD for WTP 3.2 RC1

Comment 10 Karen Butzke

2010-05-13 10:33:32 EDT

verified fixed in build WTP-I-3.2.0-20100513045407

Comment 11 Valentin Baciu

2010-06-16 13:20:56 EDT

Closing.