Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311080

Summary: opening a generated canonical metamodel file in java editor causes JPT update thread to run
Product: [WebTools] Dali JPA Tools Reporter: Karen Butzke <karenfbutzke>
Component: GeneralAssignee: Karen Butzke <karenfbutzke>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: kaloyan, neil.hauge
Version: 2.3Flags: neil.hauge: pmc_approved? (david_williams)
neil.hauge: pmc_approved? (raghunathan.srinivasan)
neil.hauge: pmc_approved? (naci.dai)
neil.hauge: pmc_approved? (deboer)
neil.hauge: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
neil.hauge: review+
Target Milestone: 2.3 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
proposed patch against head none

Description Karen Butzke CLA 2010-04-29 14:08:24 EDT

    
Comment 1 Karen Butzke CLA 2010-04-29 14:13:34 EDT
Created attachment 166541 [details]
proposed patch against head

The fix for this is simple and low risk.  The bug was a copy/paste error in a setter that was causing a property change notification to be fired when the file was opened.  That triggered our update thread.  Would be good to fix this since it is unnecessary churn.
Comment 2 Neil Hauge CLA 2010-05-03 17:59:30 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This is a serious performance issue.  When encountered, this bug slows down performance of all Workbench tasks.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 

User must know to keep metamodel files closed.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Developer tested.

* Give a brief technical overview. Who has reviewed this fix? 
See Comment 1.  I have reviewed this fix.

* What is the risk associated with this fix? 

Very low risk.
Comment 3 Karen Butzke CLA 2010-05-04 09:46:50 EDT
checked in to HEAD
Comment 4 Karen Butzke CLA 2010-05-10 15:31:48 EDT
Verified fixed in build WTP-I-3.2.0-20100507065327