Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311074

Summary: [api] Should org.eclipse.jst.jsp.core.internal.util.FacetModuleCoreSupport be public API
Product: [WebTools] WTP Source Editing Reporter: Andrew McCulloch <Andrew.McCulloch>
Component: jst.jspAssignee: jst.jsp <jst.jsp-inbox>
Status: RESOLVED WONTFIX QA Contact: Nitin Dahyabhai <thatnitind>
Severity: enhancement    
Priority: P3 CC: Andrew.McCulloch, cameron.bateman, carlin.rogers, ccc, konstantin, raghunathan.srinivasan
Version: unspecifiedKeywords: api
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Andrew McCulloch CLA 2010-04-29 13:31:40 EDT 
Build Identifier: M20100211-1343

FacetModuleCoreSupport provides useful API for dealing with DynamicWebProjects.  I have found myself duplicating most of these methods in my own code and it would be nice if this internal API was public.

Reproducible: Always
Comment 1 Nitin Dahyabhai CLA 2010-05-03 18:53:36 EDT 
Flattering, but no.  The class isn't primarily for convenient access to the Faceted Project Framework and Module Core APIs, it's there to give us safe and reasonable fallbacks when they're absent from the workspace project or the IDE.  I'm not keen on those fallback values and algorithms being part of our API.
Comment 2 Cameron Bateman CLA 2010-05-04 13:51:56 EDT 
What about moving a copy and/or overridable super-class to somewhere more common?
Comment 3 Nitin Dahyabhai CLA 2010-05-04 16:18:03 EDT 
Reopening for consideration, although this one's public only because I couldn't use it otherwise (CSS and HTML have package-protected versions).
Comment 4 Nitin Dahyabhai CLA 2012-09-24 11:08:03 EDT 
Resolving.  Not going to add it as public API.