Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 311053

Summary: Build Properties tests fail intermittently on windows
Product: [Eclipse Project] PDE Reporter: Curtis Windatt <curtis.windatt.public>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, caniszczyk, darin.eclipse
Version: 3.6Flags: curtis.windatt.public: review+
ankur_sharma: review+
Target Milestone: 3.7 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 312783    
Attachments:
Description Flags
Patch
none
test projects zip
none
Updated Fix
none
Updated Fix + cleanup + extra testcase
none
test projects zip none

Description Curtis Windatt CLA 2010-04-29 11:59:46 EDT 
The tests were updated to run correctly on linux (bug 300740), but have failed several times on Windows.  The second failure could be because of a failed existence check when setting up the test (the test uses the same project as the previous test).

The tests are being disabled for M7.

Marker count for build.properties1 expected:<[3]> but was:<[0]>

junit.framework.ComparisonFailure: Marker count for build.properties1 expected:<[3]> but was:<[0]>
at org.eclipse.pde.ui.tests.build.properties.AbstractBuildValidationTest.verifyBuildPropertiesMarkers(AbstractBuildValidationTest.java:116)
at org.eclipse.pde.ui.tests.build.properties.BuildPropertiesValidationTest.testBuildPropertiesTwo(BuildPropertiesValidationTest.java:86)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:376)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:209)
at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:195)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4041)

	Resource '/org.eclipse.pde.tests.build.properties.two/build.properties' already exists.

org.eclipse.core.internal.resources.ResourceException: Resource '/org.eclipse.pde.tests.build.properties.two/build.properties' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:305)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:292)
at org.eclipse.core.internal.resources.Resource.checkCopyRequirements(Resource.java:244)
at org.eclipse.core.internal.resources.Resource.assertCopyRequirements(Resource.java:145)
at org.eclipse.core.internal.resources.Resource.copy(Resource.java:546)
Comment 1 Curtis Windatt CLA 2010-05-05 10:54:51 EDT 
Ankur, can you try and reproduce the test failures on your windows machine?
Comment 2 Ankur Sharma CLA 2010-05-20 08:29:36 EDT 
Created attachment 169325 [details]
Patch
Comment 3 Ankur Sharma CLA 2010-05-20 08:30:39 EDT 
Created attachment 169327 [details]
test projects zip
Comment 4 Curtis Windatt CLA 2010-05-20 10:41:12 EDT 
Fix works on linux, I'm assuming that Ankur was fixing them on WinXP.  Will try on the Mac too, just in case.
Comment 5 Curtis Windatt CLA 2010-05-20 11:22:36 EDT 
Created attachment 169361 [details]
Updated Fix

This fix includes the fix for bug 312783.  It also adds the tests back into the main suite, organizes the imports and changes code formatting slightly.
Comment 6 Curtis Windatt CLA 2010-05-20 11:24:59 EDT 
Ankur, please double check my changes.

Darin and Chris, please review.
Comment 7 Curtis Windatt CLA 2010-05-20 11:25:37 EDT 
+1 for my updated patch.  Tests pass on Linux and Mac.
Comment 8 Ankur Sharma CLA 2010-05-21 07:10:22 EDT 
+1
Comment 9 Darin Wright CLA 2010-05-25 16:48:59 EDT 
*** Bug 312783 has been marked as a duplicate of this bug. ***
Comment 10 Curtis Windatt CLA 2010-05-26 15:28:08 EDT 
Tests pass on windows 7.

Darin has asked to put these off until 3.7.  It is very late in RC3 and the tests are in no way critical.
Comment 11 Ankur Sharma CLA 2010-06-26 15:23:17 EDT 
Created attachment 172842 [details]
Updated Fix + cleanup + extra testcase

Renamed the test cases to better names
Added an extra test case for bug 292763
Comment 12 Ankur Sharma CLA 2010-06-26 15:24:59 EDT 
Created attachment 172843 [details]
test projects zip

will go to /org.eclipse.pde.ui.tests/tests/build.properties/build.properties.tests.zip

Delete old zips from that folder
Comment 13 Curtis Windatt CLA 2010-06-28 15:15:11 EDT 
3.7 builds have started, so you can commit the changes if you are happy with them Ankur.  After its committed I'll synch up and check that the changes don't break the linux tests.
Comment 14 Ankur Sharma CLA 2010-06-30 14:16:20 EDT 
Fixed in HEAD
Comment 15 Curtis Windatt CLA 2010-08-03 14:19:17 EDT 
The tests have been passing consistently.  Verified.