Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 310933

Summary: Release Train Requirement: API. Projects should leverage only published APIs of dependencies.
Product: [Technology] EGit Reporter: Matthias Sohn <matthias.sohn>
Component: CoreAssignee: Project Inbox <egit.core-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mathias.kinzler, mn, remy.suen, robin
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 319287, 348277    
Bug Blocks: 310924    

Description Matthias Sohn CLA 2010-04-28 19:21:30 EDT
known discouraged access problems: 

---------------------------------------------------------------
bundle org.eclipse.egit.core has the following illegal usages of :

- bundle org.eclipse.core.resources
  - package org.eclipse.core.internal.resources
    - type ResourceException 

---------------------------------------------------------------
bundle org.eclipse.egit.ui has the following illegal usages of :

- bundle org.eclipse.compare
  - package org.eclipse.compare.internal
    - type ContentChangeNotifier

- bundle org.eclipse.team.core
  - package org.eclipse.team.internal.core.history
    - type LocalFileRevision

- bundle org.eclipse.team.ui
    - package org.eclipse.team.internal.ui
      - type IPreferenceIds
      - type StorageTypedElement
      - type TeamUIMessages
      - type TeamUIPlugin
      - type Utils
    - package org.eclipse.team.internal.ui.actions
      - type TeamAction
    - package org.eclipse.team.internal.ui.history
      - type FileRevisionTypedElement
    - package org.eclipse.team.internal.ui.synchronize  
      - type EditableSharedDocumentAdapter 
      - type LocalResourceTypedElement
    - package org.eclipse.team.internal.ui.wizards
      - type ConfigureProjectWizard

- bundle org.eclipse.ui.ide
  - package org.eclipse.ui.internal.ide
    - type IDEWorkbenchPlugin
    - type StatusUtil
  - package org.eclipse.ui.internal.wizards.datatransfer
    - type WizardProjectsImportPage
Comment 1 Matthias Sohn CLA 2010-05-04 20:16:29 EDT
problems in org.eclipse.egit.core have been fixed with
http://egit.eclipse.org/r/#change,632
which has been merged as 30235a88e38ab0483798b2e21d62dc76620af152
Comment 2 Mathias Kinzler CLA 2011-03-18 10:38:59 EDT
I believe we are clean here now. Can you double-check and close this accordingly?
Comment 3 Matthias Sohn CLA 2011-06-02 20:21:33 EDT
re-checked access restriction violation 

EGit (1.0.0) in Indigo:

org.eclipse.egit.ui.internal.search.PatternUtils
uses 
org.eclipse.search.internal.core.text.PatternConstructor

org.eclipse.egit.ui.internal.dialogs.CommitDialog
uses 
org.eclipse.ui.internal.IWorkbenchGraphicConstants
org.eclipse.ui.internal.WorkbenchImages

JGit (1.0.0) has no violations of access restrictions
Comment 4 Matthias Sohn CLA 2011-06-06 06:22:11 EDT
re-checked access restriction violation after some violations have been fixed

EGit (1.0.0) violates the following access restrictions in Indigo:

org.eclipse.egit.ui.internal.search.PatternUtils
uses 
org.eclipse.search.internal.core.text.PatternConstructor

JGit (1.0.0) has no violations of access restrictions in Indigo
Comment 5 Mykola Nikishov CLA 2012-03-03 11:12:35 EST
[Batch change] Remove passed Target Milestones

If anyone on CC list is going to fix/implement this, feel free to assign a new, post-1.3/2.0, target milestone.
Comment 6 Robin Stocker CLA 2013-09-27 10:34:28 EDT
Marking as fixed as this is old now.