Bugzilla – Full Text Bug Listing
| Summary: | Dialog font changes affects the 'Breakpoints' view | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Remy Suen <remy.suen> | ||||||||||
| Component: | Debug | Assignee: | Michael Rennie <Michael_Rennie> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | darin.eclipse, Michael_Rennie | ||||||||||
| Version: | 3.6 | Flags: | Michael_Rennie:
review+
darin.eclipse: review+ |
||||||||||
| Target Milestone: | 3.6 RC1 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 166682 [details]
patch
The SWT Factory was setting dimension hints which explicitly sets the font to the dialog font. Since this is used else where I added util methods to the abstract breakpoint editor to create check and radio buttons that avoids the dimension hints/dialog font.
Please review/approve. Created attachment 166817 [details]
updated patch
A better fix might be to not force dialog font just to compute the metrics for a button. The method that does this is only called from our factory, so removing the LOC that does this also fixes the bug. This patch also contains two removals of the use of method setButtonDimensionHint() outside of the factory.
+1 for this being fixed in 3.6RC1 Created attachment 166822 [details]
updated fix
I also found that the 'conditional' check button does not change font in the properties dialog when the dialog font has been changed. This update fixes that issue as well.
(In reply to comment #5) > I also found that the 'conditional' check button does not change font in the > properties dialog when the dialog font has been changed. This update fixes that > issue as well. Yes, you can see that button as the odd one out in my screenshot. I should've explicitly pointed that out while I was writing the original comment. Thanks, Michael. +1 for patch. Applied/Fixed. |
Created attachment 166109 [details] Screenshot depicting the horro in question. I20100425-2000 1. Window > Preferences > General > Appearance > Colors and Fonts 2. Basic > Dialog Font 3. Click the 'Edit...' button and increase the font size a bit. 4. Click 'OK' to close the dialog. 5. Create a Java breakpoint somewhere. 6. Window > Show View > Other... > Debug > Breakpoints 7. Select the breakpoint you added. 8. Cower in fear at your super-sized view.