Bugzilla – Full Text Bug Listing
| Summary: | [LinkedResources] Import > File System > Advanced: "Copy into workspace" should be "Create links in workspace" | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||||
| Component: | IDE | Assignee: | Serge Beauchamp <serge> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Serge Beauchamp <serge> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, markus.kell.r, mober.at+eclipse, Szymon.Brandys | ||||||
| Version: | 3.6 | Flags: | markus.kell.r:
review+
|
||||||
| Target Milestone: | 3.6 RC1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 302702 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Markus Keller
It used to be that way (a similar wording) but was asked to be changed specifically by Matin. Well, yes... I did suggest a "Copy into Workspace" option because that would relate to the "Import Existing Projects into Workspace" wizard, which does have this option. As a user not thinking about the history of the feature, I find the meaning of "Copy into Workspace" easier to understand than "Link into workspace" (what does (link into mean?) I must admit, though, that I didn't see the option in context with other options, so it might be that this does feel unnatural related to its slave options. Not sure which argument is stronger here. Perhaps we'll want a radio group with (a) Copy into workspace and (b) Link into workspace where the slave options are enabled when Link is chosen? "Link into workspace" would be wrong, but my suggestion is "Create links in workspace". I can see a far relationship to the "Import Existing Projects into Workspace", but I think other factors are more important here. It's also strange that an option in an "Advanced" section is enabled by default. 2 radios could be an option, but I think it's clear that an Import wizard with "Advanced > Create links in workspace" unchecked will copy the resources. Let's also hear what Dani thinks, he should be back online tomorrow. Markus is right about the slave options and using "Create..." would also be more consistent with the options above that checkbox plus the ones below, which all start with "Create". +1 to fix this for RC1. Created attachment 166760 [details]
Fix - now uses "Create links in workspace"
Is the mainline clear for commits now, by the way?
Can Dani, Markus, or Szymon review this fix so I can commit it please? Thanks, Created attachment 166811 [details] Fix 2 > Is the mainline clear for commits now, by the way? It's clear in the sense that HEAD is open (see Paul's message on platform-ui-dev). But as you've certainly seen on the mailing lists, the endgame rules must be followed now (e.g. for RC1, you need a +1 from another committer). (In reply to comment #5) > Created an attachment (id=166760) [details] [diff] The tooltip is unnecessary now. The mnemonic should always be set as early as possible in the label. "Fix 2" is the first patch with these problems fixed. +1 for RC1. Serge, please release if you agree. (In reply to comment #7) > Created an attachment (id=166811) [details] > Fix 2 > > > Is the mainline clear for commits now, by the way? > > It's clear in the sense that HEAD is open (see Paul's message on > platform-ui-dev). But as you've certainly seen on the mailing lists, the > endgame rules must be followed now (e.g. for RC1, you need a +1 from another > committer). > > > (In reply to comment #5) > > Created an attachment (id=166760) [details] [details] [diff] > > The tooltip is unnecessary now. The mnemonic should always be set as early as > possible in the label. "Fix 2" is the first patch with these problems fixed. > > +1 for RC1. Serge, please release if you agree. Ok, that sounds good, thanks. This is now fixed on head. |