Bugzilla – Full Text Bug Listing
| Summary: | Revert the Navigator support of DROP_LINK | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Serge Beauchamp <serge> | ||||||
| Component: | UI | Assignee: | Serge Beauchamp <serge> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert | ||||||
| Version: | 3.6 | Flags: | daniel_megert:
review+
|
||||||
| Target Milestone: | 3.6 RC1 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 302441 | ||||||||
| Attachments: |
|
||||||||
|
Description
Serge Beauchamp
Created attachment 165909 [details]
Patch
Now fixed on head. Serge, I quickly tested the patch and something still looks wrong: if I move a file from the OS explorer over a folder in the Navigator I get a [+] (good) but when I then press the Shift modifier I get DND.MOVE feedback but it should remain [+]. When I then drop, it doesn't move but shows the dialog (showing the dialog is good but the feedback should be DND.COPY). Created attachment 165940 [details]
Additional fix
now doesn't accept move or link drop operation, as before.
(In reply to comment #3) > Serge, I quickly tested the patch and something still looks wrong: if I move a > file from the OS explorer over a folder in the Navigator I get a [+] (good) but > when I then press the Shift modifier I get DND.MOVE feedback but it should > remain [+]. When I then drop, it doesn't move but shows the dialog (showing the > dialog is good but the feedback should be DND.COPY). Thanks pointing it out. It now behaves as it used to - change the drop to DND.DROP_NONE in such case. I didn't check the code but when I try the scenario from comment 3 it still shows MOVE feedback after pressing Shift and moving around. (In reply to comment #6) > I didn't check the code but when I try the scenario from comment 3 it still > shows MOVE feedback after pressing Shift and moving around. It looks fine to me. When I hold <shift> while dragging, it turns to the 'invalid drop operation' cursor, as it used to do. Note that the 'Additional fix' patch isn't committed on head yet. Can you please review it? Thanks, >It looks fine to me.
To me now too. Not sure what happened before.
+1 for RC1.
Thanks, now committed to head. Verified in N20100516-2000. |