Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 309660

Summary: Caret not visible
Product: [Eclipse Project] Platform Reporter: Daoen Pan <daoenpan>
Component: SWTAssignee: Platform-SWT-Inbox <platform-swt-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, daoenpan, eclipse.felipe, jkwuc89, lshanmug, macocha, remy.suen, skovatch
Version: 3.6Keywords: triaged
Target Milestone: ---   
Hardware: Macintosh   
OS: Mac OS X   
Whiteboard: stalebug
Attachments:
Description Flags
My first patch to implement the feature
none
my full preference
none
Looks good on Windows XP
none
second patch with bugfix
none
third patch with bugfix
none
third patch with bugfix none

Description Daoen Pan CLA 2010-04-19 08:10:22 EDT
Build Identifier: I20100312-1448

i do like the dark color theme for text based editors. but the black I-Beam cursor in dark background is really annoying. Eclipse can not change the color of the cursor.

Reproducible: Always
Comment 1 Daoen Pan CLA 2010-04-19 08:12:58 EDT
Created attachment 165264 [details]
My first patch to implement the feature

two screenshot for the result

http://dev.consideo-ag.com/downloads/ibeam.png
http://dev.consideo-ag.com/downloads/cursor_pref.png
Comment 2 Dani Megert CLA 2010-04-19 08:30:46 EDT
The OS automatically chooses the color depending on the current background on the fly, that's how it's done in all text widgets. One static color is not enough because you can have many different backgrounds.
Comment 3 Daoen Pan CLA 2010-04-19 08:55:34 EDT
(In reply to comment #2)
> The OS automatically chooses the color depending on the current background on
> the fly, that's how it's done in all text widgets. One static color is not
> enough because you can have many different backgrounds.


This did not happen for StyledText based editor such as text and java editor, on at least Windows and MaOSX. My cursor is always black.
Comment 4 Dani Megert CLA 2010-04-19 09:00:06 EDT
Can you attach a screenshot? There was a bug on the Mac but that got fixed for 3.5.1.
Comment 5 Daoen Pan CLA 2010-04-19 09:05:14 EDT
(In reply to comment #4)
> Can you attach a screenshot? There was a bug on the Mac but that got fixed for
> 3.5.1.

http://dev.consideo-ag.com/downloads/inv_ibeam.png

as you see, the cursor is really hard to see.
Comment 6 Daoen Pan CLA 2010-04-19 09:07:41 EDT
i habe try this with 3.5 and 3.6 on macosx-cocoa 10.6  and windows 7.
Comment 7 Dani Megert CLA 2010-04-19 09:09:16 EDT
Indeed. Which OS? Could you export all your preferences and attach them here?
Also, can you provide a picture that also shows the caret in the text.
Comment 8 Daoen Pan CLA 2010-04-19 09:11:44 EDT
Created attachment 165270 [details]
my full preference
Comment 9 Daoen Pan CLA 2010-04-19 09:16:26 EDT
(In reply to comment #7)
> Indeed. Which OS? Could you export all your preferences and attach them here?
> Also, can you provide a picture that also shows the caret in the text.

MacOSX 10.6 and Windows 7. 

the color of caret is OK.
http://dev.consideo-ag.com/downloads/caret.png
Comment 10 Dani Megert CLA 2010-04-19 09:20:04 EDT
Created attachment 165272 [details]
Looks good on Windows XP
Comment 11 Daoen Pan CLA 2010-04-19 14:21:57 EDT
Ah, my mistake, it looks also good on Windows 7. only cocoa not good.
Comment 12 Dani Megert CLA 2010-04-20 03:09:14 EDT
>Ah, my mistake, it looks also good on Windows 7. only cocoa not good.
OK. Are you sure that you are using latest 3.6 or 3.5.1 or 3.5.2 build?

Looks similar to bug 275589.
Comment 13 Daoen Pan CLA 2010-04-20 04:13:03 EDT
(In reply to comment #12)
> >Ah, my mistake, it looks also good on Windows 7. only cocoa not good.
> OK. Are you sure that you are using latest 3.6 or 3.5.1 or 3.5.2 build?
> 
> Looks similar to bug 275589.

Yes, i am sure with my eclipse version.
Comment 14 Felipe Heidrich CLA 2010-04-20 09:00:43 EDT
This bug is only on cocoa, right ?
Comment 15 Daoen Pan CLA 2010-04-20 14:51:36 EDT
Created attachment 165479 [details]
second patch with bugfix
Comment 16 Daoen Pan CLA 2010-04-20 14:58:06 EDT
Created attachment 165480 [details]
third patch with bugfix
Comment 17 Daoen Pan CLA 2010-04-20 14:59:46 EDT
Created attachment 165481 [details]
third patch with bugfix
Comment 18 Scott Kovatch CLA 2010-04-20 15:53:16 EDT
Is this no longer an SWT bug? Looks like it's being addressed in the text editor.
Comment 19 Dani Megert CLA 2010-04-21 02:48:06 EDT
>Is this no longer an SWT bug? Looks like it's being addressed in the text
>editor.
Yes it is an SWT bug: the caret should be white on black/dark background (see bug 275589 for a similar problem in the past).

The initial request was to workaround this but Text is not adding a preference for that, see comment 2.
Comment 20 Dani Megert CLA 2010-05-19 08:00:33 EDT
*** Bug 313504 has been marked as a duplicate of this bug. ***
Comment 21 Keith Wedinger CLA 2010-05-19 08:06:38 EDT
Based on testing I did this morning, this issue is present in following Eclipse versions:

Version: 3.5.2
Build id: M20100211-1343

Version: 3.6.0
Build id: I20100513-1500
Comment 22 Silenio Quarti CLA 2011-10-07 13:54:03 EDT
*** Bug 357248 has been marked as a duplicate of this bug. ***
Comment 23 Lakshmi P Shanmugam CLA 2017-07-03 07:46:05 EDT
Bug triaged, visit https://wiki.eclipse.org/SWT/Devel/Triage for more
information.
Comment 24 Eclipse Genie CLA 2020-04-13 17:48:48 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.