Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 309274

Summary: Missing @since tag when adding new API classes not reported
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: API ToolsAssignee: Vikas Chandra <Vikas.Chandra>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ed, stephan.herrmann
Version: 3.6   
Target Milestone: 4.11 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/136668
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=bdd84b1398930391b6c4e597eb58aa3b0fd6dbfc
Whiteboard:
Bug Depends on:    
Bug Blocks: 544977    

Description Dani Megert CLA 2010-04-15 05:01:26 EDT 
I20100414-1200.

We have a hole in the API tooling story: when adding a new API package plus a new API class, no API tooling error is reported (as defined by the preferences).

The error is only reported once the package is added to the manifest. Unfortunately, out of the box the severity for missing package is set to 'Ignore'.

Not sure we want to change that default so late in the game but maybe we could dynamically adjust that setting for projects that have API tooling enabled.
Comment 1 Eclipse Genie CLA 2018-12-27 04:40:14 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Dani Megert CLA 2018-12-27 09:54:52 EST 
> Unfortunately, out of the box the severity for missing package is set to 'Ignore'

We should at least set it to 'Warning'.
Comment 3 Eclipse Genie CLA 2019-02-11 05:41:55 EST 
New Gerrit change created: https://git.eclipse.org/r/136668
Comment 5 Vikas Chandra CLA 2019-02-12 01:54:54 EST 
Used this defect for comment#2
Comment 6 Vikas Chandra CLA 2019-02-15 04:49:39 EST 
Can bug reporter or bug assignee please verify this defect for 4.11M3?
Comment 7 Dani Megert CLA 2019-02-15 05:37:29 EST 
Verified with eclipse-SDK-I20190213-1800-win32-x86_64.
Comment 8 Ed Willink CLA 2019-03-02 09:11:53 EST 
(In reply to Dani Megert from comment #2)
> > Unfortunately, out of the box the severity for missing package is set to 'Ignore'
> 
> We should at least set it to 'Warning'.

No. This is a really irritating unjustified change. About 25% of my plugins now have a warning.

This bug is that there is a NEW package that is not exported.

It should not apply

a) if there is no API tooling for a plugin

b) the package was already not exported in the baseline.
Comment 9 Stephan Herrmann CLA 2019-12-02 15:28:19 EST 
Do we have other options for solving the request from comment 0, so that the unloved warning can be reverted to ignore (or info)?

I assume the real difficulty is in this scenario: New package introduced in version X, but no @since tags added, and no Export-Package - so the new thing is not really API, yet. When later the package is exported, say in version X+1, how exactly will API tools react?

1. will it cry that a "@since X+1" is needed (which doesn't match the time when the feature was implemented)? 

2. will it remain silent in version X+1, if it find the implementation already existed in version X?

If (2), maybe that's a "bug" that can be fixed in API tools?

Would we want separate since tags for Java and Export-Package headers? Or is it actually fair to say "@since X+1", if that's the point where the thing became API?