Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 309159

Summary:

[visualization] Google widgets crash application in offline situations

Product:

[RT] RAP

Reporter:

Austin Riddle <austin.riddle>

Component:

Incubator

Assignee:

Austin Riddle <austin.riddle>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Fix to prevent the application from crashing.	none

Description Austin Riddle

2010-04-14 12:34:47 EDT

As per discussion here:
  http://www.eclipse.org/forums/index.php?t=msg&th=163950&start=0&

The Google widgets should not crash the host application if the Google remote API cannot be loaded.

Comment 1 Austin Riddle

2010-04-14 12:37:52 EDT

At this juncture, I propose just catching the exception and logging a message to the console and ultimately an alert if a console is not available.

Comment 2 Austin Riddle

2010-04-14 12:52:58 EDT

Created attachment 164853 [details]
Fix to prevent the application from crashing.

Although it would be nice to have the widgets show some message in the UI about why they were unable to load, that can be addressed in a separate bug.  

At this point, there are just a few cases to consider:

1) The application attempts to load the Google API without an internet connection
2) The application loses its internet connection after load of the Google API.

The attached patch addresses Case 1) by preventing the application from crashing. If further notification is necessary to the client, then the application should detect the lack of an internet connection and not instantiate the widgets at all and/or notify the user if appropriate.

Case 2 is already handled by the Google API.  Once the library is loaded there is no need for a connection as far as I know/have tested.

Patch committed to CVS HEAD.

Comment 3 Austin Riddle

2010-04-14 13:00:57 EDT

There is a case 3) which is that there is some problem with the Google site hosting the API, in which case the application would not be able to detect the exceptional condition until it happens.  This is a case where it would be nice to have a user message. A separate bug should be opened for this.