Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 308696

Summary:

CVSFetch scm references don't handle empty connection method

Product:

[Eclipse Project] PDE

Reporter:

Andrew Niefer <aniefer>

Component:

Build

Assignee:

pde-build-inbox <pde-build-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

darin.eclipse, kim.moir

Version:

3.6

Target Milestone:

3.6 M7

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

305157

Attachments:

Description	Flags
patch	none

Description Andrew Niefer

2010-04-09 15:55:13 EDT

The eclipse nightly build uses map file repository locations that look like this:

kmoir@dev.eclipse.org:/cvsroot/eclipse

notice there is no connection method.

CVSFetchTaskFactory#asReference assumes the repository location starts with a separator and contains the connection method
:extssh:kmoir@dev.eclipse.org:/cvsroot/eclipse


We will need to handle the case when there is no connection method.

Comment 1 Darin Wright

2010-04-12 14:14:59 EDT

Created attachment 164603 [details]
patch

This patch makes parsing of CVS map entries more robust. A protocol does not need to be specified (defaults to :pserver when not specified). As well, Windows paths with the ":" character are recognized and and | is used as the separator in this case.

Andrew, can you test this patch?

Comment 2 Andrew Niefer

2010-04-12 15:39:31 EDT

Seems good to me, thanks Darin.