Bugzilla – Full Text Bug Listing
| Summary: | [explorer] DTD, XML, and XML Schema "new" context menu items should be grouped together | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Justin Berstler <bjustin> | ||||||||
| Component: | wst.xml | Assignee: | Nitin Dahyabhai <thatnitind> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Nitin Dahyabhai <thatnitind> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | david_williams, gindik, thatnitind, valentinbaciu | ||||||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
thatnitind: pmc_approved? (raghunathan.srinivasan) thatnitind: pmc_approved? (naci.dai) thatnitind: pmc_approved? (deboer) thatnitind: pmc_approved? (neil.hauge) thatnitind: pmc_approved? (kaloyan) |
||||||||
| Target Milestone: | 3.2 M7 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | PMC_approved | ||||||||||
| Bug Depends on: | 308557, 308558, 308559 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Justin Berstler
In the child bugs, I attached patches which suggest a menuGroupId value of "org.eclipse.wst.xml.new.menuGroup". While the actual value is not of incredible importance to me, all three contributions will need to use the same value in order for them to be grouped together. Requesting PMC approval...just in case. I suspect we'll have to create a bug for XSL as well. I was wondering if it is not safer to constrain these contributions to the XML perspective? <with variable="activeWorkbenchWindow.activePerspective"> <equals value="org.eclipse.wst.xml.ui.perspective"/> </with> Otherwise, the XML shortcuts will show up in all perspectives. I know XML resources are commonly used in many development scenarios, so perhaps this was the original intent? (In reply to comment #3) Sounds correct to me. Justin? (In reply to comment #4) > (In reply to comment #3) > Sounds correct to me. Justin? While I cannot confirm or deny that this is an appropriate way to scope these actions to a given perspective, I would definitely prefer having these actions scoped to the XML perspective. In general, this would allow applications that build on top of WTP to selectively add these actions to contexts (possibly defined downstream) where they also make sense - as opposed to trying to remove them from contexts where these actions do not make sense. That being said, I still think these actions should be explicitly grouped together rather than just being thrown in with any actions which do not specify a menuGroupId. Can you sum this up and net this out for PMC review? What's being changed? Is it complete, or is there follow on work to do? Created attachment 166303 [details]
complete patch for DTD, XML, XSD, and XSL
This is a patch for the 4 main XML plug-ins. It neither adds nor removes actions or features and it doesn't change any strings. What it does do is group the New wizards for the 4 file types together on the common navigator's context menu, so that instead of them mingling with other file types alphabetically, they're contained within their own section, as well as defaulting to being on the context menu only in the XML Perspective.
Created attachment 166304 [details]
before image
Created attachment 166305 [details]
after image
(In reply to comment #6) > Can you sum this up and net this out for PMC review? What's being changed? Is > it complete, or is there follow on work to do? Attachment 166303 [details] is the entire proposed change. Looks good. Thanks. Was released. |