Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 308326

Summary: Validation Framework invokes the V1 validators too often
Product: [WebTools] WTP Common Tools Reporter: Wini Mark <wmmark>
Component: wst.validationAssignee: Wini Mark <wmmark>
Status: CLOSED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P1 CC: ccc, jsholl, karasiuk, thatnitind, valentinbaciu
Version: 3.0.4Flags: ccc: review+
Target Milestone: 3.0.5 P   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=313384
Whiteboard:
Bug Depends on:    
Bug Blocks: 313630    
Attachments:
Description Flags
Patch to fix the EE validator performance problem
none
Use the extension point to allow the validator to specify if the validation is done by Project
none
revised patch none

Description Wini Mark CLA 2010-04-07 09:51:07 EDT 
Build Identifier: WTP 3.2

Validation Framework invokes the V1 validator too often which causes a performance problem. The validation framework now invokes the V1 validator per resource within the project, but it should only invoke the validator per project. 

Reproducible: Always

Steps to Reproduce:
1.Have a EE project with lots of resources
2.Right click on project and select 'validate'
3.It takes quite a while to validate the project
Comment 1 Wini Mark CLA 2010-04-21 13:37:54 EDT 
Created attachment 165605 [details]
Patch to fix the EE validator performance problem
Comment 2 Valentin Baciu CLA 2010-05-06 14:56:17 EDT 
Comment on attachment 165605 [details]
Patch to fix the EE validator performance problem 

This patch is just a workaround. We need a real fix.
Comment 3 Wini Mark CLA 2010-05-13 14:57:11 EDT 
Created attachment 168441 [details]
Use the extension point to allow the validator to specify if the validation is done by Project
Comment 4 Gary Karasiuk CLA 2010-05-18 08:20:48 EDT 
Created attachment 168905 [details]
revised patch

I had to revise the patch, to:

1) fix a spelling mistake in a constant
2) update copyright info
3) cleanup the logic
4) add documentation to the schema file
Comment 5 Gary Karasiuk CLA 2010-05-18 08:21:49 EDT 
Since I changed the patch please review and test it.
Comment 6 Wini Mark CLA 2010-05-18 10:44:46 EDT 
Gary, thanks for reviewing and modifying the patch. I have run some tests on it by adding the extension in a V1 validator to confirm that the validator is called per project. Also I run some random tests on validating different projects both in build and manual scenario to ensure the validation works as before. 

Could you please commit the patch to both wtp 3.0.5 and wtp 3.2? Thank you.
Comment 7 Carl Anderson CLA 2010-05-18 12:01:31 EDT 
To get this into HEAD you will need to clone this bug and attach the latest patch (and if desired for WTP 3.2.0, we will need PMC approval).
Comment 8 Wini Mark CLA 2010-05-18 12:11:05 EDT 
Created the bug 313384 for committing the patch in WTP 3.2
Comment 9 Carl Anderson CLA 2010-05-20 16:54:56 EDT 
I approve of this fix.
Comment 10 Carl Anderson CLA 2010-05-21 08:34:25 EDT 
Committed to R3_0_5_patches
Comment 11 Valentin Baciu CLA 2010-06-16 13:19:29 EDT 
Closing.