Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 308252

Summary: EMF's Lock class doesn't restore/propogate InterruptedExceptions
Product: [Modeling] EMF Services Reporter: Min Idzelis <min123>
Component: TransactionAssignee: EMF Services Transaction inbox <emfservices.transaction-inbox>
Status: CLOSED MOVED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, dmisic, pierre-charles.david, syedatif
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Propagate InterruptedExceptions none

Description Min Idzelis CLA 2010-04-06 14:13:26 EDT 
Build Identifier: 

Proper handling of InterruptedExceptions is a must, but especially in classes designed to deal with Locks. 

The EMF lock class swallowed interrupts in some cases. This means that interrupting a thread performing an acquire might cause upstream code to fail to receive the expected interrupt. 


Reproducible: Always
Comment 1 Min Idzelis CLA 2010-04-06 14:14:03 EDT 
Created attachment 163946 [details]
Propagate InterruptedExceptions
Comment 2 Anthony Hunter CLA 2010-05-11 10:35:27 EDT 
So via Bug 306987 you are both proposing we apply the patch for Helios? Is this something that will be of any risk?
Comment 3 Syed Atif CLA 2010-05-12 11:47:05 EDT 
I am not aware of any bugs this may help solve. Though this may make the lock class more concurrent, what effects will it have on existing applications? The given change may make the Lock class less aggressive.

For example, there is an addition of throwing an InterruptedException in the uiSafeAcquire method. What are the side effects of this when a transaction needs to begin and has already been interrupted? Existing applications may just log the exception and give up on the transaction.

I think we need to test EMFT applications intensively to see what other side effects this may have. The JUnits for EMFT are also pretty comprehensive.
Comment 4 Anthony Hunter CLA 2010-05-12 12:46:32 EDT 
(In reply to comment #3)
> I am not aware of any bugs this may help solve. [snip]

So not for Helios then...
Comment 5 Pierre-Charles David CLA 2022-05-14 09:51:52 EDT 
Eclipse EMF Transaction is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/emf-transaction.

If this issue is relevant to you and still present in the latest release:

* Create a new issue at https://github.com/eclipse/emf-transaction/issues/.
  * Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  * In the GitHub description, start with a link to this bugzilla ticket
  * Optionally add new content to the description if it can helps towards resolution
* Update bugzilla ticket
  * Add to "See also" property (up right column) the link to the newly created GitHub issue
  * Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  * Set status as CLOSED MOVED

All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for EMF Transaction will be archived and made read-only.
Comment 6 Pierre-Charles David CLA 2022-09-04 12:15:18 EDT 
Replaced with https://github.com/eclipse/emf-transaction/issues/13