Bugzilla – Full Text Bug Listing
| Summary: | Make Zest 2.0 contribution to Eclipse | ||
|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Miles Parker <milesparker> |
| Component: | GEF-Legacy Zest | Assignee: | gef-inbox <gef-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | ahunter.eclipse, caniszczyk, irbull, salilsay, schlamp, steeg, zoltan.ujhelyi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Miles Parker
Thanks for keeping on top of this Miles. The CQ for this work is actually here: http://dev.eclipse.org/ipzilla/show_bug.cgi?id=3851 Because of the size of the contribution, I had to do a bit more leg work, which I have now done (EclipseCon slowed me down a bit). Once I upload the required material it shouldn't take too long. Let me know if you're interested in helping to maintain Zest 2.0 (especially the layouts). I know you have a good understanding of the new API. Aha! Great. And yep, I'd be happy to help out where I can. I'm assuming that this API will be provisional for a while? I think that would be good as hopefully people will be experimenting with it as I have. BTW, what I'm working on is a kind of frankenstein melding of EMF.Editor and Zest so that we can get support for DAG structures. I've done a bunch of stuff with Zest for a product I'm working on and I'll be putting a simplified version of that into AMP. If it fits into Zest better than I'll let you know. Does the Zest 2.0 contribution include the Zest compatibility later to allow Zest 1.0 clients migrate to Zest 2.0? FWIW, I've found the API to be pretty compatible out of the box.. (In reply to comment #3) > Does the Zest 2.0 contribution include the Zest compatibility later to allow > Zest 1.0 clients migrate to Zest 2.0? It currently doesn't and we will obviously not remove the Zest 1.0 builds until we have an upgrade story. There are several different ways we can go with this, but at this point it's too early to tell. Right now I want to focus on getting the Zest 2.0 code into a branch so we can start flushing it out / fixing the API etc... Ahah! Looks like it's approved. :) Can we throw it up on CVS now? :D The API looks promising. Can you give any information when/how will it be integrated? Thanks for the information. Ian, I'd be happy to help with this if there is anything I can do. Me too. It seems that if we can get the CQ taken care of then we could just put it in a git repos, right? I am using the the code from http://eclipse-soc.googlecode.com/svn/trunk/2009-treeviewsforzest/ in an e4 RCP. As I am having some issues (contextListener not catching the resize events) I wonder if there is a later code somewhere. Where can I ask for this? I am making a qualitative analysis software for my own PhD. It will be GPLed. (In reply to comment #10) > I am making a qualitative analysis software for my own PhD. It will be GPLed. Hi Salil, That sounds very interesting! I hope you'll keep us up to date on progress. As a note, GPL and EPL are considered to be incompatible (http://www.eclipse.org/legal/eplfaq.php#GPLCOMPATIBLE) so perhaps you'll consider releasing under EPL instead. cheers, Miles We talked about this on the GEF call and decided that Zest 2.0 would be a great candidate for GIT + Tycho. Chris said he would help me with some of the logistics. Chris, how do we get a GIT repo at Eclipse? Do we just put a request in with the Webmaster? Ian, Yeah that's right. See: http://wiki.eclipse.org/Git Webmaster can create a new repository for you. Just open a bug against Eclipse Foundation > Community > Git. However, Eclipse committers with shell accounts can create new repositories: (In reply to comment #13) > Ian, > > Yeah that's right. See: > > http://wiki.eclipse.org/Git > > Webmaster can create a new repository for you. Just open a bug against Eclipse > Foundation > Community > Git. However, Eclipse committers with shell accounts > can create new repositories: Miles is correct here. Please create the bug :) For the build, let me know when you're ready and I'll help you. I plan on having a sample project available for you to look at soon. I've got the Zest 2.0 code organized, and the examples all updated (they compile, there are problems in a few of the viewer examples). Since we are going to use git for Zest 2.0, I have put this in a git repo and put it on github for now: https://github.com/irbull/org.eclipse.zest_2_0 Next stop is eclipse.org. A Git container for GEF has been set up after Ian requested it in bug 332260. The next step seems to be setting up the Zest repo, either via shell (I have restricted shell access only), or I suppose by asking for it in bug 332260 - the full repo path would be something like /gitroot/gef/org.eclipse.zest.git. I have added dot4zest, a target platform and some fixes in my GitHub fork. We could push that into the new repo, or Ian's and merge the other stuff then. I've attempted to push Zest to the new repo, but you're right, we need full shell access for that. I've requested an org.eclipse.zest.git repo to be created. ok, I'm going to go out on a limb and mark this bug as fixed. I've committed the Zest 2.0 code to git.eclipse.org/gitroot/gef/org.eclipse.zest. If I've done something wrong, please re-open. Small lesson learnt, use the proper e-mail address for all your 'git' work. I development machine seemed to know about my gmail address, so all my local git commits used that. However, eclipse.org didn't recognize that as committer e-mail address. I have merged dot4zest into the new Git repo (including a target platform). I have also looked into a possible compatibility layer and re-read bug 283252 which discusses API changes. I think we could easily add a deprecated compatibility layer that would make most usage of the Zest 1.x API work with Zest 2.0 (all but three of the examples compile). For the remaining use cases, we could maintain a 1.x release (as discussed in bug 283252). Would this be a way to release Zest 2.0 with Indigo? Should we keep this bug open until we have sorted out the build and release? I have started collecting documentation on Zest 2.0 at http://wiki.eclipse.org/Zest, including some pointers on migrating from 1.x - additions and corrections are very welcome of course. I've set up a basic Tycho build for Zest 2.0. It creates a p2 repository and runs the headless tests, some details are at http://wiki.eclipse.org/Zest#Setup I've set up an initial Hudson job for Zest 2.0 nightly builds at https://hudson.eclipse.org/hudson/job/gef-zest-nightly/ It creates a p2 repository at https://hudson.eclipse.org/hudson/job/gef-zest-nightly/lastSuccessfulBuild/artifact/targetPlatform/ (In reply to comment #22) > I've set up an initial Hudson job for Zest 2.0 nightly builds at > https://hudson.eclipse.org/hudson/job/gef-zest-nightly/ > > It creates a p2 repository at > https://hudson.eclipse.org/hudson/job/gef-zest-nightly/lastSuccessfulBuild/artifact/targetPlatform/ Cool. Is there a promoted site for these? (In reply to comment #23) > Cool. Is there a promoted site for these? There's no other site yet, current plan is to make one available after Indigo. |