Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 307525

Summary: Deprecated method seems to be reported as an API change
Product: [Eclipse Project] PDE Reporter: Olivier Thomann <Olivier_Thomann>
Component: API ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, john.arthorne, kim.moir, Michael_Rennie
Version: 3.6Flags: Michael_Rennie: review+
Target Milestone: 3.6 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed fix none

Description Olivier Thomann CLA 2010-03-30 09:53:04 EDT 
From bug 307398 comment 4, it looks like a deprecated method appears in the API freeze report.
This needs to be investigated.
Comment 1 Olivier Thomann CLA 2010-03-30 12:16:24 EDT 
I found where this delta is collected as an API change. Even if this is not strictly speaking an API change it might still affect the way the API should be used.
I can either filter out deprecation changes from the API Freeze report or I can make the label about the delta more verbose.
Comment 2 John Arthorne CLA 2010-03-30 12:41:08 EDT 
(In reply to comment #1)
> I can either filter out deprecation changes from the API Freeze report or I can
> make the label about the delta more verbose.

I personally don't see it as something that needs to show up in the API freeze report, but it might be useful information for the community. I'll bring this up on the PMC call tomorrow and let you know the consensus.
Comment 3 Olivier Thomann CLA 2010-03-30 13:33:10 EDT 
Created attachment 163429 [details]
Proposed fix

This fix completely removes all deprecation changes from API freeze report by ignoring them inside the delta visitor.
Comment 4 Dani Megert CLA 2010-03-31 03:07:18 EDT 
The report is the wrong place because it only lists unapproved changes i.e. even API changes don't show up there once approved by the PMC and I don't think the PMC needs to approve deprecating stuff.

Having said that, a separate report of all new deprecated APIs compared to the previous release would be a very good thing: we could then verify that all deprecated APIs are indeed documented in
    org.eclipse.platform.doc.isv/porting/3.6/recommended.html
    org.eclipse.jdt.doc.isv/porting/3.6/recommended.html
Comment 5 Olivier Thomann CLA 2010-03-31 10:32:03 EDT 
So I'll remove them from the API freeze report.
Comment 6 Olivier Thomann CLA 2010-03-31 10:35:00 EDT 
Released for 3.6M7.
Michael, please verify.
Comment 7 Olivier Thomann CLA 2010-03-31 10:38:02 EDT 
Opened bug 307740 for the new report.
Comment 8 Olivier Thomann CLA 2010-03-31 10:39:28 EDT 
Fixed.
Comment 9 Dani Megert CLA 2010-04-01 05:08:56 EDT 
>Fixed.
I still see the issue in N20100331-2000. When is the fix going "live" to the builder?
Comment 10 John Arthorne CLA 2010-04-01 08:44:55 EDT 
(In reply to comment #9)
> I still see the issue in N20100331-2000. When is the fix going "live" to the
> builder?

I suspect the builder picks up new API tools once per milestone. Kim, please correct me if I'm wrong. I suggest we just add a line to the exception file in the meantime.
Comment 11 Kim Moir CLA 2010-04-01 10:25:20 EDT 
We only use new bundles in the builder once a milestone, or more frequently if we have bug to address in the builder.  I have to update the bundles for another bug anyways so this many happen earlier than the next milestone.